lint: pin golangci-lint version #671
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 18 18
Lines 3305 3305
=======================================
Hits 3123 3123
Misses 170 170
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 24, 2025
Merged
Owner
|
I would rather keep the latest golangci-lint version. Thanks for the suggestion |
Contributor
Author
|
No worries. A lot of OSS project maintainers wont even look at PRs unless all the CI checks pass but that's not the case here. |
NathanBaulch
referenced
this pull request
Sep 25, 2025
* lint: pin golangci-lint version * feat: preserve type alias in WithoutBy * feat: preserve type alias in DropByIndex --------- Co-authored-by: Samuel Berthe <dev@samuel-berthe.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the golangci-lint version so that contributors aren't blocked by unrelated CI issues if a new version happens to be released. This PR pins it to the previous version
v2.4which this codebase passes. Versionv2.5was released a couple of days ago with new issues to be addressed.