Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

saltfs-migration: Upgrade Salt on all machines. Steps:
- Stop all salt-master and salt-minion services. Because we're upgrading
  Salt by two major versions at once, there are no guarantees that the
  masters and minions with different versions will be able to
  communicate.
- Use the install script to re-install Salt on each machine, the master
  first then the minion.
- Restart the salt-master and salt-minion services; pay attention to the
  system logs in case of startup failure.

Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

saltfs-migration: Upgrade Salt on all machines. Steps:
- Stop all salt-master and salt-minion services. Because we're upgrading
  Salt by two major versions at once, there are no guarantees that the
  masters and minions with different versions will be able to
  communicate.
- Use the install script to re-install Salt on each machine, the master
  first then the minion.
- Restart the salt-master and salt-minion services; pay attention to the
  system logs in case of startup failure.
- Do NOT run a highstate until all minions and masters have been updated
  to Salt 2016.3.0.

Back-port #36552 to carbon

The newer version of this module will prefer to use the unzip command
instead of the python zipfil module for unzipping.
This works around https://bugs.python.org/issue15795,
namely a bug where the zipfile module does not respect permissions.
This will fix our Android toolchain `archive.extracted` states.

Note that this version of the module does not include
saltstack/salt#36552,
so keep the `archive_user` argument to `archive.extracted` states.

`archive.extracted` sets ownership only on the `if_missing` path,
so ensure Salt sets ownership on all the extracted files by unsetting
`if_missing`, which (as a new feature) now defaults to `name`.
This now refers to the top level extracted directory,
so all extracted files will be properly owned by `servo/servo`,
which ensures we are able to run the `android` command as the `servo`
user to download the platform and build tools in the `cmd.run` state.

The newer version of this module will prefer to use the unzip command
instead of the python zipfil module for unzipping.
This works around https://bugs.python.org/issue15795,
namely a bug where the zipfile module does not respect permissions.
This will fix our Android toolchain `archive.extracted` states.

Note that this version of the module does not include
saltstack/salt#36552,
so keep the `archive_user` argument to `archive.extracted` states.

`archive.extracted` sets ownership only on the `if_missing` path,
so ensure Salt sets ownership on all the extracted files by unsetting
`if_missing`, which (as a new feature) now defaults to `name`.
This now refers to the top level extracted directory,
so all extracted files will be properly owned by `servo/servo`,
which ensures we are able to run the `android` command as the `servo`
user to download the platform and build tools in the `cmd.run` state.

Because the `unzip` binary will be used to extract the zip files,
require the `android-dependencies` `pkg.installed` state from
`archive.extracted` states that extract zip archives
to ensure that the `unzip` binary is available.

The newer version of this module will prefer to use the unzip command
instead of the python zipfile module for unzipping.
This works around https://bugs.python.org/issue15795,
namely a bug where the zipfile module does not respect permissions.
This will fix our Android toolchain `archive.extracted` states.

Note that this version of the module does not include
saltstack/salt#36552,
so keep the `archive_user` argument to `archive.extracted` states.

`archive.extracted` sets ownership only on the `if_missing` path,
so ensure Salt sets ownership on all the extracted files
by unsetting `if_missing`, which defaults to `name`.
This now refers to the top level extracted directory,
so all extracted files will be properly owned by `servo/servo`,
which ensures we are able to run the `android` command as the `servo`
user to download the platform and build tools in the `cmd.run` state.

Because the `unzip` binary will be used to extract the zip files,
require the `android-dependencies` `pkg.installed` state from
`archive.extracted` states that extract zip archives
to ensure that the `unzip` binary is available.

Homebrew recently changed their packaging of Salt and Python, using a
virtualenvs for Salt. Because we were pinning an old version of Salt,
but not the rest of Homebrew, this caused problems where pip was not
being resolved properly. Update Salt to the latest version to fix this.

As part of the update, also update some states to avoid deprecated
parameters in favor of newer ones:
- archive.extracted: archive_user -> user, group
- cmd.run: user, group -> runas

Note that due to saltstack/salt#36552,
`archive.extracted` states still have the archive_user argument to
ensure parent directories are made with the correct permissions.

saltfs-migration: Upgrade Salt on all machines. Steps:
- Stop all salt-master and salt-minion services. Because we're upgrading
  Salt by two major versions at once, there are no guarantees that the
  masters and minions with different versions will be able to
  communicate.
- Use the install script to re-install Salt on each machine, the master
  first then the minion.
- Restart the salt-master and salt-minion services; pay attention to the
  system logs in case of startup failure.
- Do NOT run a highstate until all minions and masters have been updated
  to Salt 2016.3.0.

The newer version of this module will prefer to use the unzip command
instead of the python zipfile module for unzipping.
This works around https://bugs.python.org/issue15795,
namely a bug where the zipfile module does not respect permissions.
This will fix our Android toolchain `archive.extracted` states.

Note that this version of the module does not include
saltstack/salt#36552,
so keep the `archive_user` argument to `archive.extracted` states.

`archive.extracted` sets ownership only on the `if_missing` path,
so ensure Salt sets ownership on all the extracted files
by unsetting `if_missing`, which defaults to `name`.
This now refers to the top level extracted directory,
so all extracted files will be properly owned by `servo/servo`,
which ensures we are able to run the `android` command as the `servo`
user to download the platform and build tools in the `cmd.run` state.

Because the `unzip` binary will be used to extract the zip files,
require the `android-dependencies` `pkg.installed` state from
`archive.extracted` states that extract zip archives
to ensure that the `unzip` binary is available.