Skip to content

Feature/error reporting #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maoxuner wants to merge 2 commits into from
Closed

Feature/error reporting #39

maoxuner wants to merge 2 commits into from

Conversation

@maoxuner
Copy link

@maoxuner maoxuner commented Jul 21, 2022 •
edited
Loading

  1. [Enhancement]Support for framework exception handler #38 Finally, I figured out that it's not necessarily rendering exception with error handler. Expected exceptions need to transform must extend RpcException. What I need is just error reporting.
  2. All exceptions will be caught by Exception, these is no need to catch HttpException or RuntimeException.
        } catch (HttpException | RuntimeException | Exception $exception) {

origin code

@tabuna
Copy link
Member

tabuna commented Jul 25, 2022

Hi @pawmaster please, could you add some tests?

@maoxuner
Copy link
Author

maoxuner commented Jul 26, 2022

@tabuna Sorry, I'm not formiliar with php unit test. Could you do the job for me?

@maoxuner
Copy link
Author

maoxuner commented Jul 26, 2022 •
edited
Loading

I've tried to throw \Exception('some message', 500) in FixtureProcedure::testAbort and then detect error message in ExpectedTest::exampleCalls but log file not exist. Logger function was called but log file not created.

@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #39 (400e003) into master (f933dfd) will not change coverage.
The diff coverage is 90.90%.

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage     99.77%   99.77%           
  Complexity      129      129           
=========================================
  Files            22       22           
  Lines           437      437           
=========================================
  Hits            436      436           
  Misses            1        1
Impacted Files Coverage Δ
src/HandleProcedure.php 95.23% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f933dfd...400e003. Read the comment docs.

tabuna added a commit that referenced this pull request Sep 1, 2022
@tabuna
refs #39 Added reporting exceptions
739382e
@tabuna tabuna mentioned this pull request Sep 1, 2022
Merged
tabuna added a commit that referenced this pull request Sep 1, 2022
@tabuna
refs #38 #39 Added reporting exceptions
12f5838
@maoxuner maoxuner closed this Sep 2, 2022
@maoxuner maoxuner deleted the feature/error-reporting branch September 2, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maoxuner @tabuna