Make sagelib compatible with mpmath 1.4#41728
Conversation
…dle mpmath types without Sage backend
…ion_doctest.py: Update class name in doctest output
|
Documentation preview for this PR (built with commit d7314e9; changes) is ready! 🎉 |
|
We'll need to bump the version requirement to |
The difference comes from not using MPMATH_SAGE, not from the version upgrade
Well, the idea is that this should work with older mpmath too. Otherwise it doesn't make sense to split it from the sage-the-distro upgrade. I think it's too soon to require 1.4, which was just released. |
It's not optional
I tried this in #41014, and while I'm sure it can be done (I got it working with the meson build but gave up due to repeated CI failures I couldn't reproduce), it requires a lot more work. The tests are not too bad, but a different set of C extensions are compiled when v1.3 is installed, and utils.pyx has a different set of cimports. |
CI is fine with 1.3. Can you give more details about that different set of C extensions you mention, and what does it break? |
|
There is a circular dependency between mpmath-1.3 and the portion of sage.libs.mpmath.utils that was deleted, but in the end it's not doing much and it looks like I was wasting my time trying to preserve it for backwards-compatibility. I just spent a while trying to cause problems and couldn't do it without essentially setting Someone added a guard to mpmath a few years ago to disable the sage backend when |
sagemathgh-41728: Make sagelib compatible with mpmath 1.4 pick sagelib changes from sagemath#40669 and sagemath#38565 for mpmath 1.4 compatibility URL: sagemath#41728 Reported by: Antonio Rojas Reviewer(s):
sagemathgh-41728: Make sagelib compatible with mpmath 1.4 pick sagelib changes from sagemath#40669 and sagemath#38565 for mpmath 1.4 compatibility URL: sagemath#41728 Reported by: Antonio Rojas Reviewer(s):
sagemathgh-41728: Make sagelib compatible with mpmath 1.4 pick sagelib changes from sagemath#40669 and sagemath#38565 for mpmath 1.4 compatibility URL: sagemath#41728 Reported by: Antonio Rojas Reviewer(s):
sagemathgh-41728: Make sagelib compatible with mpmath 1.4 pick sagelib changes from sagemath#40669 and sagemath#38565 for mpmath 1.4 compatibility URL: sagemath#41728 Reported by: Antonio Rojas Reviewer(s):
pick sagelib changes from #40669 and #38565 for mpmath 1.4 compatibility