New method map_coefficients for Laurent series#41598
Merged
vbraun merged 15 commits intosagemath:developfrom Mar 22, 2026
Merged
New method map_coefficients for Laurent series#41598vbraun merged 15 commits intosagemath:developfrom
map_coefficients for Laurent series#41598vbraun merged 15 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit bacce66; changes) is ready! 🎉 |
tscrim
requested changes
Feb 6, 2026
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
tscrim
approved these changes
Feb 9, 2026
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
Last little doc things to be more explicit about the data.
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Contributor
Author
|
Thanks for all the comments! The CI caught a small mistake, it should be fine now. (edit: force pushed a typo correction in the last commit message) |
d311d8b to
91db921
Compare
tscrim
reviewed
Feb 10, 2026
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
Ah, right, sorry for forgetting about that. Thank you. Let's do that in one other place (and a second because I'm paranoid). This is the last thing before a positive review.
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Collaborator
|
Sorry for the slow response. Thank you; positive review. |
Contributor
Author
|
Thank you for your time! |
Contributor
Author
|
There was a merge conflict with #41549. |
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 28, 2026
sagemathgh-41598: New method `map_coefficients` for Laurent series This PR adds a method `map_coefficients` for Laurent series. Such a method already exists for formal power series, polynomials, etc. While I was on that file, I took the opportunity to remove the deprecated function `is_LaurentSeries`, removed in sagemath#38266 which was merged on 2024-08-03. I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. URL: sagemath#41598 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Rubén Muñoz--Bertrand, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 6, 2026
sagemathgh-41598: New method `map_coefficients` for Laurent series This PR adds a method `map_coefficients` for Laurent series. Such a method already exists for formal power series, polynomials, etc. While I was on that file, I took the opportunity to remove the deprecated function `is_LaurentSeries`, removed in sagemath#38266 which was merged on 2024-08-03. I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. URL: sagemath#41598 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Rubén Muñoz--Bertrand, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 15, 2026
sagemathgh-41598: New method `map_coefficients` for Laurent series This PR adds a method `map_coefficients` for Laurent series. Such a method already exists for formal power series, polynomials, etc. While I was on that file, I took the opportunity to remove the deprecated function `is_LaurentSeries`, removed in sagemath#38266 which was merged on 2024-08-03. I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. URL: sagemath#41598 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Rubén Muñoz--Bertrand, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 18, 2026
sagemathgh-41598: New method `map_coefficients` for Laurent series This PR adds a method `map_coefficients` for Laurent series. Such a method already exists for formal power series, polynomials, etc. While I was on that file, I took the opportunity to remove the deprecated function `is_LaurentSeries`, removed in sagemath#38266 which was merged on 2024-08-03. I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. URL: sagemath#41598 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Rubén Muñoz--Bertrand, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 21, 2026
sagemathgh-41598: New method `map_coefficients` for Laurent series This PR adds a method `map_coefficients` for Laurent series. Such a method already exists for formal power series, polynomials, etc. While I was on that file, I took the opportunity to remove the deprecated function `is_LaurentSeries`, removed in sagemath#38266 which was merged on 2024-08-03. I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. URL: sagemath#41598 Reported by: Rubén Muñoz--Bertrand Reviewer(s): Rubén Muñoz--Bertrand, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method
map_coefficientsfor Laurent series. Such a method already exists for formal power series, polynomials, etc.While I was on that file, I took the opportunity to remove the deprecated function
is_LaurentSeries, removed in #38266 which was merged on 2024-08-03.I have also improved the documentation: now no docstring nor method description should be missing. I also fixed minor stuff in the documentation, and linting.
📝 Checklist