Update uv lock file and improve uv installation procedure#41461
Update uv lock file and improve uv installation procedure#41461vbraun merged 1 commit intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 53a15a0; changes) is ready! 🎉 |
|
the version constraint on Cython was unnecessarily restrictive. Cython 3.2.4 works for me fine. |
|
It would be good to have a more detailed doc on when |
…cedure <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Monthly update of the uv lock file (using `uv sync --upgrade`). Moreover, I've added the build dependencies also to the dev group, so that they can be installed by a simple `uv sync` instead of having to manually install them via `uv pip ...`. Apart from being shorter, this has the additional advantage that those build dependencies are now locked as well. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41461 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
No, there is no connection between sage-the-distro and the uv lock file. They are used for completely different installation methods. They only instance when you need to update all lock files at the same time is when a new version of a python project (say numpy or cython) requires changes in sage that are not compatible with the old version. Thanks for the review! |
|
It is possible to install sage-distro into a uv venv, no? And package versions should be kept uniform as much as possible across sage-distro/uv/conda, if only to get clearer results from the CI |
|
the CI pov is illustrated by this PR - if primecountpy versions were updated uniformly, CI results would have been more mean6 |
Maybe, I've never tried that.
Sure, that's a good reason too. |
sagemathgh-41461: Update uv lock file and improve uv installation procedure <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Monthly update of the uv lock file (using `uv sync --upgrade`). Moreover, I've added the build dependencies also to the dev group, so that they can be installed by a simple `uv sync` instead of having to manually install them via `uv pip ...`. Apart from being shorter, this has the additional advantage that those build dependencies are now locked as well. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41461 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
Monthly update of the uv lock file (using
uv sync --upgrade). Moreover, I've added the build dependencies also to the dev group, so that they can be installed by a simpleuv syncinstead of having to manually install them viauv pip .... Apart from being shorter, this has the additional advantage that those build dependencies are now locked as well.📝 Checklist
⌛ Dependencies