update m4ri to gcc-15-supporting version#40132
Conversation
this will fix sagemath/sage#40132
this will fix sagemath/sage#40132
|
This picks up the right version of m4ri. But my compilation then runs into an error compiling m4rie-20200125. Presumably that should also be updated to version 20250128 of m4rie. (Not that I understand any of them). |
|
Thanks. I'll deal with m4rie here too. |
|
@chriswuthrich - does it work now? |
|
With the added m4rie update, this now allows me to build sage completely. Huge thanks! |
|
If I'd remember what to do and how to give a positive review, I would do it, but I haven't reviewed for a long time. |
click on "Files changed" tab above, you'll see a green "Review changes" button |
|
Should we update line 4 in build/pkgs/m4rie/checksums.ini from bitbucket to github, too?
I will click anyway on the positive review button. I assume that no tests are needed here, otherwise please tell me to run them. As to the correctness of the changes I have full confidence that Dima knows what he is doing.... |
The bitbucket URL is certainly still valid, I don't know whether it's the mirror, or the main site for m4ri. @malb might tell us. |
|
Hi all, Sorry for the confusion. For both M4RI and M4RIE Github is the main repository and Bitbucket is the mirror. |
|
This comment is now obsolete, do not mind it.
Sorry, you sentence is a bit confusing, if github is not the main repository and bitbucket is the mirror, where is the main repository :) ? |
|
Argh, how am I this bad at this! I've edited it now. Thanks |
Cryptographers... they commicate in code on encrypted channels... T'ja. |
|
|
OK, I'll change the hosting to github |
sagemathgh-40132: update m4ri to gcc-15-supporting version this in particular corrects m4ri's pkg-config file, which is not working for gcc-15, see e.g. BRiAl/BRiAl#58 and the sage-develop posts ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40132 Reported by: Dima Pasechnik Reviewer(s): Chris Wuthrich
sagemathgh-40132: update m4ri to gcc-15-supporting version this in particular corrects m4ri's pkg-config file, which is not working for gcc-15, see e.g. BRiAl/BRiAl#58 and the sage-develop posts ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40132 Reported by: Dima Pasechnik Reviewer(s): Chris Wuthrich
sagemathgh-40132: update m4ri to gcc-15-supporting version this in particular corrects m4ri's pkg-config file, which is not working for gcc-15, see e.g. BRiAl/BRiAl#58 and the sage-develop posts ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40132 Reported by: Dima Pasechnik Reviewer(s): Chris Wuthrich
|
@orlitzky - can please gentoo get this update of m4ri from https://github.com/malb/m4ri/releases/tag/20250128 |
|
yep, done |
sagemathgh-40133: brial update to 1.2.14 among other upgrades, this is robust w.r.t. broken system m4ri packages with incorrect .pc file So this should complete the fix started in sagemath#40132 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40133 Reported by: Dima Pasechnik Reviewer(s): Tobias Diez
this in particular corrects m4ri's pkg-config file, which is not working for gcc-15, see e.g. BRiAl/BRiAl#58 and the sage-develop posts
📝 Checklist
⌛ Dependencies