Faster conversion from numpy array to matrix mod 2#39219
Merged
vbraun merged 2 commits intosagemath:developfrom Jan 4, 2025
Merged
Faster conversion from numpy array to matrix mod 2#39219vbraun merged 2 commits intosagemath:developfrom
vbraun merged 2 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit bab7cd4; changes) is ready! 🎉 |
tscrim
reviewed
Dec 31, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 1, 2025
sagemathgh-39219: Faster conversion from numpy array to matrix mod 2 As in the title. Estimated 50× speedup. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (Reuses the `numpy_util` module from sagemath#38834 for the utility function) Reverse direction: sagemath#39152 URL: sagemath#39219 Reported by: user202729 Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the title. Estimated 50× speedup.
📝 Checklist
(Reuses the
numpy_utilmodule from #38834 for the utility function)Reverse direction: #39152