Define __iter__ method in iterator types#39182
Merged
vbraun merged 2 commits intosagemath:developfrom Jan 18, 2025
Merged
Conversation
This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types
|
Documentation preview for this PR (built with commit 9ec9a9a; changes) is ready! 🎉 |
user202729
approved these changes
Dec 22, 2024
Contributor
user202729
left a comment
There was a problem hiding this comment.
It has always been required, just that the implementation detail of Python < 3.13 probably happen to ignore this issue.
(I don't think test is necessary for such a trivial thing)
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39182: Define __iter__ method in iterator types This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types URL: sagemath#39182 Reported by: Antonio Rojas Reviewer(s): user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39182: Define __iter__ method in iterator types This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types URL: sagemath#39182 Reported by: Antonio Rojas Reviewer(s): user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39182: Define __iter__ method in iterator types This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types URL: sagemath#39182 Reported by: Antonio Rojas Reviewer(s): user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39182: Define __iter__ method in iterator types This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types URL: sagemath#39182 Reported by: Antonio Rojas Reviewer(s): user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39182: Define __iter__ method in iterator types This is required for iterator types and seems to be enforced in Python 3.13 https://docs.python.org/3/library/stdtypes.html#iterator-types URL: sagemath#39182 Reported by: Antonio Rojas Reviewer(s): user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for iterator types and seems to be enforced in Python 3.13
https://docs.python.org/3/library/stdtypes.html#iterator-types