Fix produce_latex_macro with Python 3.13#39181
Closed
antonio-rojas wants to merge 3 commits intosagemath:developfrom
Closed
Fix produce_latex_macro with Python 3.13#39181antonio-rojas wants to merge 3 commits intosagemath:developfrom
antonio-rojas wants to merge 3 commits intosagemath:developfrom
Conversation
After PEP 667 implementation [1] locals() changes within an exec call are not propagated [1] python/cpython@b034f14
|
Documentation preview for this PR (built with commit 0c4343c; changes) is ready! 🎉 |
kwankyu
reviewed
Dec 22, 2024
| exec('from ' + module + ' import ' + real_name) | ||
| loc = locals() | ||
| if sys.version_info.minor < 13: | ||
| exec('from ' + module + ' import ' + real_name) |
Collaborator
There was a problem hiding this comment.
You may add a comment here referring to this PR.
5 tasks
Contributor
|
I'd rather doing #39184 instead. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2024
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
sagemathgh-39184: Refactor produce_latex_macro Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PEP 667 implementation [1] locals() changes within an exec call are not propagated
[1] python/cpython@b034f14