Remove giac integration from GiNaC#38669
Merged
vbraun merged 2 commits intosagemath:developfrom Sep 22, 2024
Merged
Conversation
If this is helping us in some way, I can't figure out how.
The source file sage/symbolic/ginac/mpoly-giac.cpp that integrates GiNaC with giac was recently removed.
|
Documentation preview for this PR (built with commit 1025ed7; changes) is ready! 🎉 |
Contributor
|
Works fine here |
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 19, 2024
Phase one of sagemath#38668 AFAICS it's not doing anything anyway. URL: sagemath#38669 Reported by: Michael Orlitzky Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase one of #38668
AFAICS it's not doing anything anyway.