Skip to content

Fix sage_bootstrap.flock for Python 3.13 (fedora-41)#38521

Merged
vbraun merged 3 commits intosagemath:developfrom
mkoeppe:sage_bootstrap_pipes
Sep 3, 2024
Merged

Fix sage_bootstrap.flock for Python 3.13 (fedora-41)#38521
vbraun merged 3 commits intosagemath:developfrom
mkoeppe:sage_bootstrap_pipes

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Aug 17, 2024

Seen on Fedora 41, which already ships Python 3.13:

https://github.com/mkoeppe/sage/actions/runs/10426436105/job/28893965205#step:11:10930

#28 943.2   [pip-24.0]   [spkg-pipinst]   File "/sage/build/bin/../sage_bootstrap/flock.py", line 15, in <module>
#28 943.2   [pip-24.0]   [spkg-pipinst]     import pipes
#28 943.2   [pip-24.0]   [spkg-pipinst] ModuleNotFoundError: No module named 'pipes'

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2024

Documentation preview for this PR (built with commit a7ed572; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Aug 17, 2024

This broke `fedora-30-standard

 [asttokens-2.4.1]   [spkg-pipinst]   File "/sage/build/bin/../sage_bootstrap/flock.py", line 108, in <genexpr>
#29 188.4   [asttokens-2.4.1]   [spkg-pipinst]     kind, ' '.join(shlex.quote(arg) for arg in command)))
#29 188.4   [asttokens-2.4.1]   [spkg-pipinst] AttributeError: 'module' object has no attribute 'quote'

https://github.com/mkoeppe/sage/actions/runs/10435004678/job/28898508679

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Aug 17, 2024

shlex.quote was added in Python 3.3, is not available in Python 2.7



try:
# Python >= 3.3
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.3?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused. If it is available from python 3.3, surely you will only get to the exception for python <3.3 not 3.13. And we never supported python 3.2 IIRC.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sage-bootstrap still supports python 2

@kiwifb
Copy link
Copy Markdown
Member

kiwifb commented Aug 22, 2024

Thanks for the added verbosity. It does not make my head in anymore.

Copy link
Copy Markdown
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is rather trivial.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Aug 22, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 27, 2024
sagemathgh-38521: Fix `sage_bootstrap.flock` for Python 3.13 (fedora-41)
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Seen on Fedora 41, which already ships Python 3.13:

https://github.com/mkoeppe/sage/actions/runs/10426436105/job/28893965205
#step:11:10930
```
sagemath#28 943.2   [pip-24.0]   [spkg-pipinst]   File
"/sage/build/bin/../sage_bootstrap/flock.py", line 15, in <module>
sagemath#28 943.2   [pip-24.0]   [spkg-pipinst]     import pipes
sagemath#28 943.2   [pip-24.0]   [spkg-pipinst] ModuleNotFoundError: No module
named 'pipes'
```

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38521
Reported by: Matthias Köppe
Reviewer(s): François Bissey, Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit 5d2e55e into sagemath:develop Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants