get rid of one sage_eval in complex numbers#38391
Merged
vbraun merged 7 commits intosagemath:developfrom Aug 3, 2024
Merged
Conversation
|
Documentation preview for this PR (built with commit 191dd38; changes) is ready! 🎉 |
Contributor
|
Depends on how much external code uses the string constructor of ℂ, this may break badly. Here are some examples Also, is it faster than |
Contributor
Author
|
This parser is not supposed to perform computations ; it should only accept inputs that are already just one complex number in full explicit form. |
Contributor
Author
|
after versus before |
mkoeppe
approved these changes
Jul 21, 2024
Contributor
mkoeppe
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this!
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 25, 2024
sagemathgh-38391: get rid of one sage_eval in complex numbers this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 31, 2024
sagemathgh-38391: get rid of one sage_eval in complex numbers this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 2, 2024
sagemathgh-38391: get rid of one sage_eval in complex numbers this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is parsing in a simple way the string input for complex number constructor, avoiding usage of
sage_evalthere📝 Checklist