Deprecate is_SchemeMorphism, is_SchemeTopologicalPoint#38296
Merged
vbraun merged 8 commits intosagemath:developfrom Aug 10, 2024
Merged
Deprecate is_SchemeMorphism, is_SchemeTopologicalPoint#38296vbraun merged 8 commits intosagemath:developfrom
is_SchemeMorphism, is_SchemeTopologicalPoint#38296vbraun merged 8 commits intosagemath:developfrom
Conversation
Contributor
Author
|
The lint failures are unrelated and come from the release of ruff 0.5.0 (https://pypi.org/project/ruff/#history) |
|
Documentation preview for this PR (built with commit de805b1; changes) is ready! 🎉 |
Collaborator
|
Here is an interesting case of a place where it might be good to leave the |
Contributor
Author
|
Well, what could be useful here: a new ABC. But I definitely don't want to wait with the removal of |
Contributor
Author
|
... or, alternatively, whether what is intended in the uses of |
Collaborator
sage: from sage.schemes.elliptic_curves.ell_point import EllipticCurvePoint_field
sage: from sage.schemes.generic.morphism import SchemeMorphism
sage: issubclass(EllipticCurvePoint_field, SchemeMorphism)
TrueThis is also mathematically sound. |
Contributor
Author
|
Thanks. So I can actually simplify many |
…d, SchemeMorphism) -> True
Contributor
Author
|
Thank you! |
Member
|
Merge conflict |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 5, 2024
sagemathgh-38296: Deprecate `is_SchemeMorphism`, `is_SchemeTopologicalPoint` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Part of: - sagemath#32414 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38296 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 16, 2026
sagemathgh-41638: remove some deprecated stuff in schemes + typing after sagemath#38277 ; Closed Date: 2024-07-24 sagemath#38296 ; Closed Date: 2024-08-10 sagemath#35467 ; Closed Date: 2024-04-27 also adding a few typing annotations in the methods "is_something" ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41638 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 20, 2026
sagemathgh-41638: remove some deprecated stuff in schemes + typing after sagemath#38277 ; Closed Date: 2024-07-24 sagemath#38296 ; Closed Date: 2024-08-10 sagemath#35467 ; Closed Date: 2024-04-27 also adding a few typing annotations in the methods "is_something" ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41638 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 23, 2026
sagemathgh-41638: remove some deprecated stuff in schemes + typing after sagemath#38277 ; Closed Date: 2024-07-24 sagemath#38296 ; Closed Date: 2024-08-10 sagemath#35467 ; Closed Date: 2024-04-27 also adding a few typing annotations in the methods "is_something" ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41638 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of:
is_Classfunctions, create abstract base classes to enable modularization #32414📝 Checklist
⌛ Dependencies