Skip to content

sage.geometry.hyperbolic_space: Add # needs#38236

Merged
vbraun merged 2 commits intosagemath:developfrom
mkoeppe:norm_needs
Jul 24, 2024
Merged

sage.geometry.hyperbolic_space: Add # needs#38236
vbraun merged 2 commits intosagemath:developfrom
mkoeppe:norm_needs

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Jun 18, 2024

Some of these are from the use of a matrix norm, which # needs scipy.

Also a norm-related change in sage.modules.free_module_integer - avoiding use of norm, which send us into symbolics land, in favor of just comparing norm squares

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit 1cce2b8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Copy Markdown
Collaborator

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Jun 18, 2024

Thanks!

@vbraun vbraun merged commit db87eb3 into sagemath:develop Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants