Graph.{[weighted_]adjacency_matrix,kirchhoff_matrix}: Support constructing End(CombinatorialFreeModule) elements#37955
Merged
vbraun merged 11 commits intosagemath:developfrom May 12, 2024
Merged
Conversation
added 7 commits
May 7, 2024 10:04
…g nrows, keyword row_keys; fix documentation
…w method _vertices_keys
mkoeppe
commented
May 7, 2024
|
Documentation preview for this PR (built with commit 98323cb; changes) is ready! 🎉 |
dcoudert
reviewed
May 8, 2024
| def _vertex_indices_and_keys(self, vertices=None, *, sort=None): | ||
| r""" | ||
| Process a ``vertices`` parameter. | ||
|
|
Collaborator
There was a problem hiding this comment.
May be you could add that this is a helper function for methods like adjacency_matrix, kirchhoff_matrix, etc.
dcoudert
approved these changes
May 10, 2024
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
LGTM.
I assume that if needed we can change the name of the new method. I don't have better option in mind.
Contributor
Author
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37955: `Graph.{[weighted_]adjacency_matrix,kirchhoff_matrix}`: Support constructing `End(CombinatorialFreeModule)` elements <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This is a follow-up after - sagemath#37692 ... to cover a few more methods. The methods can now create endomorphisms of free modules whose bases are indexed by the vertices. To help with this, we make the `matrix` constructor a bit more flexible. This is also preparation for making the spectral graph theory methods ready for `CombinatorialFreeModule`: - sagemath#37943 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37955 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37955: `Graph.{[weighted_]adjacency_matrix,kirchhoff_matrix}`: Support constructing `End(CombinatorialFreeModule)` elements <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This is a follow-up after - sagemath#37692 ... to cover a few more methods. The methods can now create endomorphisms of free modules whose bases are indexed by the vertices. To help with this, we make the `matrix` constructor a bit more flexible. This is also preparation for making the spectral graph theory methods ready for `CombinatorialFreeModule`: - sagemath#37943 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37955 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up after
matrix,Graph.incidence_matrix,LinearMatroid.representation: Support constructingHom(CombinatorialFreeModule)elements #37692... to cover a few more methods. The methods can now create endomorphisms of free modules whose bases are indexed by the vertices. To help with this, we make the
matrixconstructor a bit more flexible.This is also preparation for making the spectral graph theory methods ready for
CombinatorialFreeModule:ModulesWithBasis: Add methodseigenvalues,eigenvectors,eigenspacesto endomorphisms #37943📝 Checklist
⌛ Dependencies