Merged
Conversation
tscrim
requested changes
May 6, 2024
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
Just a few little things. LGTM overall.
Store sorted circuit lengths and other minor edits.
tscrim
approved these changes
May 7, 2024
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
Thank you. LGTM. I can only assume the tests pass since the CI tester is broken...
|
Documentation preview for this PR (built with commit 02a4fc3; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
Member
|
CI fails because the tests fail (src/sage/algebras/orlik_solomon.py) |
Contributor
Author
|
Oops, excuse me for that slip. Now corrected. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 15, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 18, 2024
sagemathgh-37930: Work on `CircuitsMatroid` Various class-specific improvements. Implementation of enumerators (e.g. `in/dependent_r_sets`) and `_closure`. (The methods `bases`, `nonbases`, `circuit_closures`, `flats`, etc., are now much faster.) The changes in `matroid.pyx` are mostly for consistency's sake (enumerators returning a `SetSystem`). URL: sagemath#37930 Reported by: gmou3 Reviewer(s): gmou3, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 27, 2024
sagemathgh-38056: `SetSystem`: Minor change to accommodate set input This change makes the code cleaner in multiple places. The PR also includes some docstring edits in `set_system.pyx`. ### ⌛ Dependencies - Depends on sagemath#37930 and sagemath#38027 URL: sagemath#38056 Reported by: gmou3 Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 29, 2024
sagemathgh-38056: `SetSystem`: Minor change to accommodate set input This change makes the code cleaner in multiple places. The PR also includes some docstring edits in `set_system.pyx`. ### ⌛ Dependencies - Depends on sagemath#37930 and sagemath#38027 URL: sagemath#38056 Reported by: gmou3 Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 31, 2024
sagemathgh-38056: `SetSystem`: Minor change to accommodate set input This change makes the code cleaner in multiple places. The PR also includes some docstring edits in `set_system.pyx`. ### ⌛ Dependencies - Depends on sagemath#37930 and sagemath#38027 URL: sagemath#38056 Reported by: gmou3 Reviewer(s): Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various class-specific improvements. Implementation of enumerators (e.g.
in/dependent_r_sets) and_closure.(The methods
bases,nonbases,circuit_closures,flats, etc., are now much faster.)The changes in
matroid.pyxare mostly for consistency's sake (enumerators returning aSetSystem).