Deprecate is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup#37898
Merged
vbraun merged 3 commits intosagemath:developfrom May 12, 2024
Merged
Deprecate is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup#37898vbraun merged 3 commits intosagemath:developfrom
is_AbelianGroup, is_DualAbelianGroup, is_MatrixGroup#37898vbraun merged 3 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit ec586f2; changes) is ready! 🎉 |
mantepse
reviewed
Apr 29, 2024
| True | ||
| """ | ||
| from sage.misc.superseded import deprecation | ||
| deprecation(37898, "the function is_AbelianGroup is deprecated; use 'isinstance(..., AbelianGroup_class)' instead") |
Contributor
There was a problem hiding this comment.
shouldn't that be use 'in Groups.Commutative', @fchapoton?
Contributor
There was a problem hiding this comment.
I just checked, yes, that's the pattern. For example:
deprecation(35999, "the function is_CommutativeAlgebra is deprecated; use '... in Algebras(base_ring).Commutative()' instead")
or
deprecation(35253, "the function is_Algebra is deprecated; use '... in Algebras(base_ring)' instead")
Contributor
Author
There was a problem hiding this comment.
I did use this pattern in these other deprecation messages when there was at least some indication that these is_... functions were used with this meaning.
But is_AbelianGroup has never been used with a meaning other than this specific isinstance test.
videlec
approved these changes
May 8, 2024
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37898: Deprecate `is_AbelianGroup`, `is_DualAbelianGroup`, `is_MatrixGroup` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37898 Reported by: Matthias Köppe Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37898: Deprecate `is_AbelianGroup`, `is_DualAbelianGroup`, `is_MatrixGroup` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37898 Reported by: Matthias Köppe Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37898: Deprecate `is_AbelianGroup`, `is_DualAbelianGroup`, `is_MatrixGroup` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37898 Reported by: Matthias Köppe Reviewer(s): Martin Rubey, Matthias Köppe, Vincent Delecroix
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 4, 2026
sagemathgh-41383: remove some deprecated stuff in groups after sagemath#37898 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41383 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 6, 2026
sagemathgh-41383: remove some deprecated stuff in groups after sagemath#37898 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41383 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies