Skip to content

Deprecate is_Monoid, is_FreeMonoid, is_FreeAbelianMonoid#37897

Merged
vbraun merged 3 commits intosagemath:developfrom
mkoeppe:is_Monoid_deprecations
May 12, 2024
Merged

Deprecate is_Monoid, is_FreeMonoid, is_FreeAbelianMonoid#37897
vbraun merged 3 commits intosagemath:developfrom
mkoeppe:is_Monoid_deprecations

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Apr 29, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 29, 2024

Documentation preview for this PR (built with commit 9fe3e99; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented May 2, 2024

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2024
4bc1e93 
sagemathgh-37897: Deprecate `is_Monoid`, `is_FreeMonoid`, `is_FreeAbelianMonoid`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37897
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
50a47a6 
sagemathgh-37897: Deprecate `is_Monoid`, `is_FreeMonoid`, `is_FreeAbelianMonoid`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37897
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
113c54f 
sagemathgh-37897: Deprecate `is_Monoid`, `is_FreeMonoid`, `is_FreeAbelianMonoid`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37897
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
ac2d18a 
sagemathgh-37897: Deprecate `is_Monoid`, `is_FreeMonoid`, `is_FreeAbelianMonoid`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37897
Reported by: Matthias Köppe
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 8dfb15d into sagemath:develop May 12, 2024
@fchapoton fchapoton mentioned this pull request Jan 4, 2026
Merged
3 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 13, 2026
e454354 
sagemathgh-41393: remove deprecated stuff in monoids/
    
after

sagemath#38280 ; Closed Date: 2024-07-24
sagemath#37897 ; Closed Date: 2024-05-12
sagemath#38184 ; Closed Date: 2024-06-22

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41393
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 14, 2026
168d9a1 
sagemathgh-41393: remove deprecated stuff in monoids/
    
after

sagemath#38280 ; Closed Date: 2024-07-24
sagemath#37897 ; Closed Date: 2024-05-12
sagemath#38184 ; Closed Date: 2024-06-22

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41393
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@mkoeppe mkoeppe

Labels

c: combinatorics t: refactoring

Projects

None yet

Milestone

sage-10.4

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoeppe @tscrim @vbraun