Reverted changes from #36986#37850
Merged
vbraun merged 2 commits intosagemath:developfrom Jun 9, 2024
Merged
Conversation
Contributor
Author
|
I am not sure whether the target branch should be develop or master, as this is a reverting PR. |
|
Documentation preview for this PR (built with commit 26696ef; changes) is ready! 🎉 |
Member
|
in all our PRs target is always develop branch |
Contributor
|
LGTM. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
sagemathgh-37850: Reverted changes from sagemath#36986 Reverted changes made in sagemath#36986 The bug in sagemath#36974 remains unsolved. Efforts are being made in sagemath#37744 to resolve the bug. Fixes sagemath#37744 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies URL: sagemath#37850 Reported by: Aman Moon Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted changes made in #36986
The bug in #36974 remains unsolved. Efforts are being made in #37744 to resolve the bug.
Fixes #37744
📝 Checklist
⌛ Dependencies