Make univariate Laurent polynomials over a field pass the TestSuite#37778
Make univariate Laurent polynomials over a field pass the TestSuite#37778vbraun merged 2 commits intosagemath:developfrom
Conversation
|
Before looking at how is coded, it is right that |
|
The Laurent polynomial gcd was done so that for I don't see any mathematical difference with your proposal outright. Can you explain more? Is it more computational? |
|
I am not sure if my proposal is better. In sage for the integers, the |
|
It's basically just you like it better than anything mathematical (say, something algebro-geometric related). That's not unreasonable. However, I think we should keep it the way it is because it will match on polynomials. This is parallel to how the gcd for I am not sure which would be faster or less code. I imagine both versions would be basically the same... |
|
I basically agree with you. Maybe not right now, but I wonder that if we may have both with a |
|
Documentation preview for this PR (built with commit f87b6fd; changes) is ready! 🎉 |
|
Thank you. |
sagemathgh-37778: Make univariate Laurent polynomials over a field pass the TestSuite <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The output of `xgcd` does not match the `gcd` output, but this is required by sagemath#17671. We change the computation to make these match. We also fix another bug as it should also take non-Laurent polynomial inputs to `xgcd`. We also implement the `euclidean_domain()` method. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37778 Reported by: Travis Scrimshaw Reviewer(s): Enrique Manuel Artal Bartolo, Travis Scrimshaw
sagemathgh-37719: Refactor ring categories A somewhat large refactoring of some of the auld classes for rings, and related categories - introducing a new category of Noetherian rings - moving some methods in appropriate categories - fixing necessary details ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. Depends on sagemath#37778 URL: sagemath#37719 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe, Travis Scrimshaw
sagemathgh-37719: Refactor ring categories A somewhat large refactoring of some of the auld classes for rings, and related categories - introducing a new category of Noetherian rings - moving some methods in appropriate categories - fixing necessary details ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. Depends on sagemath#37778 URL: sagemath#37719 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe, Travis Scrimshaw
sagemathgh-37719: Refactor ring categories A somewhat large refactoring of some of the auld classes for rings, and related categories - introducing a new category of Noetherian rings - moving some methods in appropriate categories - fixing necessary details ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. Depends on sagemath#37778 URL: sagemath#37719 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe, Travis Scrimshaw
The output of
xgcddoes not match thegcdoutput, but this is required by #17671. We change the computation to make these match. We also fix another bug as it should also take non-Laurent polynomial inputs toxgcd.We also implement the
euclidean_domain()method.📝 Checklist
⌛ Dependencies