Make matroid copy and deepcopy simply return self#37670
Merged
vbraun merged 4 commits intosagemath:developfrom Apr 12, 2024
Merged
Make matroid copy and deepcopy simply return self#37670vbraun merged 4 commits intosagemath:developfrom
copy and deepcopy simply return self#37670vbraun merged 4 commits intosagemath:developfrom
Conversation
gmou3
added a commit
to gmou3/sage
that referenced
this pull request
Mar 26, 2024
TODO: add FlatsMatroid copy tests in matroid.pyx after sagemath#37670
Member
|
merge conflict |
Contributor
Author
|
I just tried and it got merged cleanly. |
Contributor
|
This "merge conflict" message means that there was a conflict when Volker tried to merge it into his integration branch. |
Contributor
|
There is a conflict with #37667; if you want, you can merge it here to resolve the conflict. |
Contributor
Author
|
Got it. Thanks! |
Contributor
|
Best to add |
|
Documentation preview for this PR (built with commit 1d1825f; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I abstracted all
copy/deepcopysubclass implementations to a generic one in the main matroid class (inmatroid.pyx).I am unsure as to whether something of value is lost with this change (e.g. relating to the manual
memopassing indeepcopy).This follows a recommendation by @mkoeppe made in #37340 (comment).
⌛ Dependencies