Merged
Conversation
c32fb73 to
0ec4126
Compare
Contributor
Collaborator
Author
Yes. But this PR should also be merged before release, of course. For this PR, we should wait and check the built documentation. I hope that the clogged ci would soon be resolved... |
|
Documentation preview for this PR (built with commit 0ec4126; changes) is ready! 🎉 |
Collaborator
Author
|
I looked over the generated doc. I see no significant changes. Looks good to me. |
Collaborator
Author
|
To keep our beta a little more stable, this PR is better to be merged together with #37129. |
Collaborator
Author
|
I found one nontrivial small change <section id="id2">
-<h2>Sageで力まかせに計算<a class="headerlink" href="#id2" title="この見出しへのパーマリンク">#</a></h2>
+<h2>Sageで力まかせに計算<a class="headerlink" href="#id2" title="Link to this heading">#</a></h2>
<p>まず要素値が乱数で与えられる <span class="math notranslate nohighlight">\(500 \times 500\)</span> 行列を作っておく．</p>There may be other small changes perhaps due to Sphinx 7. In my opinion, these can be investigated later. |
Contributor
|
Let's merge it. I also looked at the diff a bit and at the formatting of some chapters. All good. |
Collaborator
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 19, 2024
sagemathgh-37334: Preparation for Sphinx 7 Based on sagemath#37129, we adjust sage for Sphinx 7. Mainly, - (once again) `sage_autodoc` is updated based on the source file of Sphinx 7. Before the arrival of Sphinx 8, hopefully, we should remove `sage_autodoc`! <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - sagemath#37129 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37334 Reported by: Kwankyu Lee Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #37129, we adjust sage for Sphinx 7. Mainly,
sage_autodocis updated based on the source file of Sphinx 7.Before the arrival of Sphinx 8, hopefully, we should remove
sage_autodoc!📝 Checklist
⌛ Dependencies