Fix build when linbox is build with fplll support#37064
Merged
vbraun merged 1 commit intosagemath:developfrom Jan 22, 2024
Merged
Fix build when linbox is build with fplll support#37064vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
Undefine flint macros that conflict with fplll variables and break build when both are included
5 tasks
|
Documentation preview for this PR (built with commit 0001320; changes) is ready! 🎉 |
tobiasdiez
approved these changes
Jan 17, 2024
Contributor
tobiasdiez
left a comment
There was a problem hiding this comment.
At #37077, I've encountered the same error and your PR fixed it. Thanks!
Contributor
Author
|
Test failure looks unrelated, setting to positive review |
mezzarobba
added a commit
to mezzarobba/sage
that referenced
this pull request
Jan 30, 2024
mezzarobba
added a commit
to mezzarobba/sage
that referenced
this pull request
Feb 3, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
sagemathgh-37193: Some fixes & improvements to autogenerated flint .pxd - flint autogen: fields of a[rc]b_poly_struct - flint autogen: remove two typedefs that don't exist in flint - move fix from sagemath#37064 to the flint interface generator - flint autogen: add warnings about generated files to the templates - regenerate flint wrappers URL: sagemath#37193 Reported by: Marc Mezzarobba Reviewer(s): Vincent Delecroix
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 11, 2024
sagemathgh-37193: Some fixes & improvements to autogenerated flint .pxd - flint autogen: fields of a[rc]b_poly_struct - flint autogen: remove two typedefs that don't exist in flint - move fix from sagemath#37064 to the flint interface generator - flint autogen: add warnings about generated files to the templates - regenerate flint wrappers URL: sagemath#37193 Reported by: Marc Mezzarobba Reviewer(s): Vincent Delecroix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefine flint macros that conflict with fplll variables and break build when both are included
See #36449 (comment)