Fix a bug for .ci/create-changes-html.sh#36871
Merged
vbraun merged 1 commit intosagemath:developfrom Dec 19, 2023
Merged
Conversation
5393540 to
542d3cc
Compare
5 tasks
542d3cc to
7e82250
Compare
|
Documentation preview for this PR (built with commit 7e82250; changes) is ready! 🎉 |
Collaborator
Author
|
Thanks! |
This was referenced Dec 15, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 17, 2023
sagemathgh-36888: Fix failure of doc preview changes when an html is removed Fixes sagemath#36887. Tested with sagemath#36892 and sagemath#36885. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - sagemath#36871 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36888 Reported by: Kwankyu Lee Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in
.ci/create-changes-html.shwhich can result in failure of doc-build workflow, as seen in #36861.For instance, from a hunk in a diff
<span class="go">(X0, X1)</span> </pre></div> </div> @@ -428,8 +426,8 @@ Default to cyclotomic base ring.</p></li> <p>A tuple of integers.</p> <p>EXAMPLES:</p> <div class="highlthe script read
428instead of reading426, which is the correct line number of modified part of a file. This caused failures.Tested in #36861.
📝 Checklist
⌛ Dependencies