`gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3, `gmpy2` 2.2.0a1 by mkoeppe · Pull Request #36351 · sagemath/sage

mkoeppe · 2023-09-28T05:22:25Z

The unreleased 2.2.x series has work on support for Python 3.12

The new version makes it necessary to tighten the requirements for MPC and MPFR.
We do the version check without pkg-config as before; changing it to pkg-config is #31348.

(The upgrade of the packages was previously done in #36775, but has now been merged here.)

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

tornaria · 2023-12-13T21:17:57Z

FWIW, we are shipping 2.2.0a1 in void linux since september. This supports python 3.12 and is available on pypi: https://pypi.org/project/gmpy2/2.2.0a1/

mkoeppe · 2023-12-13T21:20:15Z

Thanks @tornaria, I'll try switching to this release!

mkoeppe · 2023-12-14T16:32:36Z

Full tests at https://github.com/mkoeppe/sage/actions/runs/7205490817

debian-bullseye has MPC 1.2.0, which passes my test in spkg-configure but is rejected by gmpy2 (it needs 1.2.1).

dimpase · 2023-12-14T16:50:46Z

we can as we often do get the MPC version from mpc.h - akin to what we do for NTL 😭

/* Define MPC version number */
#define MPC_VERSION_MAJOR 1
#define MPC_VERSION_MINOR 3
#define MPC_VERSION_PATCHLEVEL 1
#define MPC_VERSION_STRING "1.3.1"

/* Macros dealing with MPC VERSION */
#define MPC_VERSION_NUM(a,b,c) (((a) << 16L) | ((b) << 8) | (c))
#define MPC_VERSION                                                     \
  MPC_VERSION_NUM(MPC_VERSION_MAJOR,MPC_VERSION_MINOR,MPC_VERSION_PATCHLEVEL)

a bit shorter than NTL code will use MPC_VERSION - which is 66049 for 1.2.1

mkoeppe · 2023-12-14T16:57:44Z

I'm just copying the test from gmpy.h

dimpase · 2023-12-14T17:06:02Z

Do you mean AC_RUN_ and not AC_LINK_?!

mkoeppe · 2023-12-14T17:08:34Z

No

mkoeppe · 2023-12-14T17:09:21Z

This is a compile-time test

dimpase · 2023-12-14T17:20:09Z

It's AC_COMPILE_ then.

Also not clear how you make sure to test for -lmpc, as you took AC_SEARCH_LIBS out.

mkoeppe · 2023-12-14T17:28:34Z

I'll get back to it later when I have a bit more time. Feel free to push a fix

dimpase · 2023-12-14T19:14:08Z

ready now, I think

mkoeppe · 2023-12-14T19:22:37Z

Thanks. I've switched the lib test to use a newer function, like I did previously in 109671e

mkoeppe · 2023-12-17T22:24:36Z

Thanks.

sagemathgh-36351: build/pkgs/gmpy2: Update to 2.2.0a1    The unreleased 2.2.x series has work on support for Python 3.12 https://github.com/aleaxit/gmpy The new version makes it necessary to tighten the requirements for MPC and MPFR. We do the version check without pkg-config as before; changing it to pkg-config is sagemath#31348.   ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on sagemath#36775 (merged here)  URL: sagemath#36351 Reported by: Matthias Köppe Reviewer(s):

tobiasdiez · 2023-12-22T05:24:19Z

Conda tests fail for this PR.

mkoeppe · 2023-12-22T05:33:14Z

I explained the principle to you in #35593 (comment)

tobiasdiez · 2023-12-22T05:55:04Z

Since when do we have the principle to just ignore tests when they don't suit you?

There is no need for sagelib to require a unreleased version of gmpy2.

mkoeppe · 2023-12-22T05:56:06Z

Tobias, stop this nonsense.

dimpase · 2023-12-22T10:08:19Z

if conda tests fail, we need to make sure this gmpy2 version (released on PyPI) makes it to Conda quickly.

I am not sure it is feasible to maintain support for two seriously different versions of gmpy2 and a bunch of libraries - unless it all just works on Conda, and the test in question breaks it for no good reason.

vbraun · 2023-12-22T11:33:04Z

Tests fail because of missing hypothesis, is this intentional?

[gmpy2-2.2.0a1] ImportError while importing test module '/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.11.1/var/tmp/sage/build/gmpy2-2.2.0a1/src/test/test_mpz.py'.
[gmpy2-2.2.0a1] Hint: make sure your test modules/packages have valid Python names.
[gmpy2-2.2.0a1] Traceback:
[gmpy2-2.2.0a1] ../../../../../../../lib/python3.11/importlib/__init__.py:126: in import_module
[gmpy2-2.2.0a1]     return _bootstrap._gcd_import(name[level:], package, level)
[gmpy2-2.2.0a1] test_mpz.py:6: in <module>
[gmpy2-2.2.0a1]     from hypothesis import assume, given, example, settings
[gmpy2-2.2.0a1] E   ModuleNotFoundError: No module named 'hypothesis'
[gmpy2-2.2.0a1] ______________________ ERROR collecting test/test_mpq.py _______________________

…/gnumpc/versions

…ctually accepts our current version

mkoeppe · 2024-01-01T01:56:31Z

With the gmpy2 upgrade here, passes all tests on the same machine where I reproduced the failures reported in #36775 (comment) with the old gmpy2.

github-actions · 2024-01-01T03:05:28Z

Documentation preview for this PR (built with commit 4bdb76d; changes) is ready! 🎉

mkoeppe · 2024-01-01T18:05:33Z

All tests passed, let's get this in.

sagemathgh-36351: `gmp` 6.3.0, `mpc` 1.3.1, `mpfr` 4.2.1, `mpfrcx` 0.6.3, `gmpy2` 2.2.0a1    The unreleased 2.2.x series has work on support for Python 3.12 https://github.com/aleaxit/gmpy The new version makes it necessary to tighten the requirements for MPC and MPFR. We do the version check without pkg-config as before; changing it to pkg-config is sagemath#31348. (The upgrade of the packages was previously done in sagemath#36775, but has now been merged here.)   ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36351 Reported by: Matthias Köppe Reviewer(s):

saraedum · 2024-04-18T00:52:50Z

if conda tests fail, we need to make sure this gmpy2 version (released on PyPI) makes it to Conda quickly.

Note that conda usually does not package alphas. Is the alpha absolutely necessary now? Does anything break badly if I just install sagelib with gmpy 2.1.x?

mkoeppe · 2024-04-18T00:58:09Z

Check what's declared in ~~build/pkgs/gmpy2/install-requires.txt~~ build/pkgs/gmpy2/version_requirements.txt

saraedum · 2024-04-18T01:03:53Z

It says gmpy2 ~=2.1.b999. Which means yes. Though that . before the b confuses me.

mkoeppe · 2024-04-18T01:06:18Z

This should accept all 2.1.x versions, or at least so I claimed in the 4bdb76d commit.

mkoeppe · 2024-04-18T01:06:53Z

Though that . before the b confuses me.

Right, that's not normalized

vbraun force-pushed the develop branch from 883e05f to e349b00 Compare November 12, 2023 16:25

dimpase force-pushed the gmpy2.2 branch from a664359 to 3060fdb Compare December 14, 2023 19:11

dimpase added s: needs review and removed s: needs work labels Dec 14, 2023

dimpase added s: positive review and removed s: needs review labels Dec 17, 2023

tobiasdiez added s: needs work and removed s: positive review labels Dec 22, 2023

Matthias Koeppe and others added 18 commits December 26, 2023 09:23

build/pkgs/mpfr: Update to 4.2.1

f789c54

build/pkgs/mpfrcx: Update to 0.6.3

0132a7b

build/pkgs/mpc: Update to 1.3.1

cd3ac16

build/pkgs/gmpy2: Update to 5ac3746047491cd5508c0705613f75a1636be6a6

2ad9ae7

build/pkgs/mpc/spkg-configure.m4: Require MPC >= 1.2.0

c678ebe

build/pkgs/mpfr/spkg-configure.m4: Require MPFR >= 4.1.0

7bf45d4

build/pkgs/gmpy2: Update to 2.2.0a1

423199c

build/pkgs/mpc/distros/repology.txt: Add https://repology.org/project…

9db6c75

…/gnumpc/versions

build/pkgs/mpc/spkg-configure.m4: Check for version using AC_LINK_IFELSE

999ae8d

fix mpc's spkg-config.m4 to reject versions <1.2.1

8a06a0e

require gmpy2 version > 2.1.*

0e34f4a

build/pkgs/mpc/spkg-configure.m4: Check for mpc_sum

3b22659

build/pkgs/gmpy2/install-requires.txt: Use a version specifier that a…

8e9bdfa

…ctually accepts our current version

build/pkgs/hypothesis: New (gmpy2 check dependency)

b14834f

build/pkgs/gmpy2/dependencies_check: New

ca30464

build/pkgs/hypothesis/dependencies: Add attrs

5383be0

build/pkgs/gmpy2/install-requires.txt: Back to only requiring >= 2.1.0

9424eca

build/pkgs/gmpy2/install-requires.txt: Accept both 2.1.x and 2.2.0a1

4bdb76d

vbraun merged commit 729f03f into sagemath:develop Jan 14, 2024

github-actions bot removed the s: positive review label Jan 14, 2024

saraedum mentioned this pull request Apr 18, 2024

sagelib v10.3 conda-forge/sagelib-feedstock#174

Merged

17 tasks

Uh oh!

Conversation

mkoeppe commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

tornaria commented Dec 13, 2023

Uh oh!

mkoeppe commented Dec 13, 2023

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

dimpase commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

dimpase commented Dec 14, 2023

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

dimpase commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

dimpase commented Dec 14, 2023

Uh oh!

mkoeppe commented Dec 14, 2023

Uh oh!

mkoeppe commented Dec 17, 2023

Uh oh!

tobiasdiez commented Dec 22, 2023

Uh oh!

mkoeppe commented Dec 22, 2023

Uh oh!

tobiasdiez commented Dec 22, 2023

Uh oh!

mkoeppe commented Dec 22, 2023

Uh oh!

dimpase commented Dec 22, 2023

Uh oh!

vbraun commented Dec 22, 2023

Uh oh!

mkoeppe commented Jan 1, 2024

Uh oh!

github-actions bot commented Jan 1, 2024

Uh oh!

mkoeppe commented Jan 1, 2024

Uh oh!

saraedum commented Apr 18, 2024

Uh oh!

mkoeppe commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saraedum commented Apr 18, 2024

Uh oh!

mkoeppe commented Apr 18, 2024

Uh oh!

mkoeppe commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mkoeppe commented Sep 28, 2023 •

edited

Loading

dimpase commented Dec 14, 2023 •

edited

Loading

dimpase commented Dec 14, 2023 •

edited

Loading

mkoeppe commented Apr 18, 2024 •

edited

Loading