Yet more more spkgs confs by dimpase · Pull Request #36332 · sagemath/sage

dimpase · 2023-09-25T14:51:36Z

a continuation of #36276 (more system Python packages support via --enable-system-site-packages)

Also, added a Cython 3.0.2 patch to fix the usage of --enable-system-site-packages option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added)

dimpase · 2023-09-25T14:52:34Z

need to add more distros/ stuff

orlitzky · 2023-09-25T15:05:55Z

We could do cython now too. The standard spkg-configure.m4 works fine. I've only tested it with cython-3.x but we'll probably have that soon from #36110

mkoeppe · 2023-09-26T16:19:50Z

Can you please redo this branch with proper merge commits for its depencies?

dimpase · 2023-09-26T16:56:22Z

by right, this branch should be based off develop, but it needs #36276, which is only in the "WIP-develop".
This gives me a headache. Anyhow, it's all in
https://github.com/dimpase/sage/tree/pr36332

mkoeppe · 2023-09-28T16:30:10Z

I'd suggest to remove the additions to hatch_nodejs_version because #36129 will remove this package.

dimpase · 2023-09-28T17:02:08Z

I'd suggest to remove the additions to hatch_nodejs_version because #36129 will remove this package.

let's not count chickens before they're hatched. If this gets it before #36129 I'll fix the latter branch, no problem

mkoeppe · 2023-09-28T17:13:57Z

Or let's not lay eggs that are unwanted?

dimpase · 2023-09-28T19:48:09Z

one cannot realistically scan all the open PRs and check for potential conflicts

mkoeppe · 2023-09-28T19:54:06Z

I know, hence my helpful comment

mkoeppe · 2023-09-30T17:26:15Z

@orlitzky In the platforms tests for --enable-system-site-packages, I see Cython compiler crashes while building sagelib, on many platforms.
https://github.com/mkoeppe/sage/actions/runs/6360039461/job/17277499571#step:12:58476

      Error compiling Cython file:
      ------------------------------------------------------------
      ...
      # distutils: libraries = NTL_LIBRARIES gmp
      ^
      ------------------------------------------------------------
  
      sage/rings/polynomial/polynomial_integer_dense_flint.pyx:1:0: Compiler crash in DebugTransform
  
  
      Compiler crash traceback from this point on:
        File "Cython/Compiler/Visitor.py", line 182, in Cython.Compiler.Visitor.TreeVisitor._visit
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Compiler/ParseTreeTransforms.py", line 4053, in visit_ModuleNode
          self.visit_FuncDefNode(nested_funcdef)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Compiler/ParseTreeTransforms.py", line 4113, in visit_FuncDefNode
          self.tb.start(arg.name)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Debugger/DebugWriter.py", line 42, in start
          self.tb.start(name, attrs or {})
        File "src/lxml/saxparser.pxi", line 841, in lxml.etree.TreeBuilder.start
        File "src/lxml/saxparser.pxi", line 769, in lxml.etree.TreeBuilder._handleSaxStart
        File "src/lxml/apihelpers.pxi", line 179, in lxml.etree._makeSubElement
        File "src/lxml/apihelpers.pxi", line 1753, in lxml.etree._tagValidOrRaise
      ValueError: Invalid tag name '.0'
      Traceback (most recent call last):
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1325, in cythonize_one_helper
          return cythonize_one(*m)
        File "/sage/local/var/lib/sage/venv-python3.10/lib/python3.10/site-packages/Cython/Build/Dependencies.py", line 1301, in cythonize_one
          raise CompileError(None, pyx_file)
      Cython.Compiler.Errors.CompileError: sage/rings/polynomial/polynomial_integer_dense_flint.pyx

Any thoughts?

orlitzky · 2023-09-30T17:40:41Z

Any thoughts?

Looks like cython/cython#5552

orlitzky · 2023-09-30T17:42:19Z

Unrelated: dev-python/stack_data was just renamed to dev-python/stack-data in Gentoo so now its distros/gentoo.txt needs an update.

build/pkgs/calver/distros/package-version.txt

dimpase · 2023-10-02T14:32:50Z

calver is for setting up python package versions via date (CalendarVersion)
And, well, the version Sage installs is 2022.6.26
(same version as in Gentoo a.t.m.)

orlitzky · 2023-10-02T14:37:36Z

calver is for setting up python package versions via date (CalendarVersion) And, well, the version Sage installs is 2022.6.26 (same version as in Gentoo a.t.m.)

But why create a package-version.txt under distros/?

dimpase · 2023-10-02T15:17:39Z

this happends when you put a bunch of .txt files in a wrong place, then move them to the right place, but...

dimpase · 2023-10-02T17:59:13Z

Any thoughts?

Looks like cython/cython#5552

I tried patching Cython with the patch they provide, still getting this error.

PS. Sorry, it's OK - I forgot how to patch Gentoo packages, and the patch got lost...

orlitzky · 2023-10-02T19:07:53Z

PS. Sorry, it's OK - I forgot how to patch Gentoo packages, and the patch got lost...

I opened a Gentoo bug to backport the patch. Otherwise cython-3.0.3 should fix it, or --without-system-cython. I'm happy with this branch if Matthias has no more comments.

dimpase · 2023-10-02T19:14:25Z

we'd also sort out these endless

Implicit noexcept declaration is deprecated. Function declaration should contain 'noexcept' keyword.

warnings, eventually

github-actions · 2023-10-10T14:51:48Z

Documentation preview for this PR (built with commit 89a6f9f; changes) is ready! 🎉

orlitzky · 2023-10-10T23:13:47Z

I don't mind the cython patch but note that it won't help when cython also comes from the system (after this PR). The cython bug you patched is fixed in cython-3.0.3 (#36416), but cython-3.0.3 has a new problem (cython/cython#5748). Hopefully 3.0.4 comes soon.

mkoeppe · 2023-10-10T23:20:47Z

Note that #36411 pins Cython to 3.0.2; waiting for review.

see sagemath#35658, in particular sagemath#35658 (comment) and later

sagemathgh-36332: Yet more more spkgs confs a continuation of sagemath#36276 (more system Python packages support via `--enable-system-site-packages`) Also, added a Cython 3.0.2 patch to fix the usage of `--enable-system- site-packages` option. Without it, and sufficiently many Python system packages, sagelib won't build. (Therefore, blocker label added) URL: sagemath#36332 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky

sagemathgh-36416: `build/pkgs/cython`: Update to 3.0.4      ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on sagemath#36332 (to remove the patch added there)  URL: sagemath#36416 Reported by: Matthias Köppe Reviewer(s):

dimpase marked this pull request as draft September 25, 2023 14:51

dimpase requested review from mkoeppe and orlitzky September 25, 2023 14:51

dimpase force-pushed the yet_more_more_spkgs-confs branch from ebb218f to 61162af Compare September 25, 2023 18:36

dimpase marked this pull request as ready for review September 26, 2023 07:51

dimpase added the s: needs review label Sep 26, 2023

orlitzky reviewed Oct 2, 2023

View reviewed changes

build/pkgs/calver/distros/package-version.txt Show resolved Hide resolved

dimpase referenced this pull request Oct 10, 2023

update cython to 3.0.2

703ec1b

dimpase force-pushed the yet_more_more_spkgs-confs branch from 9459c5d to 89a6f9f Compare October 10, 2023 13:31

orlitzky and others added 16 commits October 15, 2023 12:03

build/pkgs/poetry_core: add Gentoo package information

72a6ed5

build/pkgs/poetry_core: add standard python spkg-configure.m4

c9e2067

more spkg-configure.m4 for python packages

8f8394c

7.1+ does not work with Sage, cf sagemath/pull/35658

41ed5b3

see sagemath#35658, in particular sagemath#35658 (comment) and later

build/pkgs/pkgconfig: Update to 1.5.5, change to wheel package

76141a6

build/pkgs/pkgconfig/SPKG.rst: Restore hand-edited version

6107a04

build/pkgs/poetry_core: Remove (again)

7d79db5

sphinx 7.x is OK

f073ed1

build/pkgs/jupyter_packaging: Remove (again)

bbd75f8

leftover standard packages without spkg-configures

43ac4ad

spkg-configure for cython

c259524

more spkg-configures and distros info

aff12df

leave hatch_nodejs_version intact, in preparation for its removal

0df6885

adjust gentoo package name

a9c3665

remove an extra copy

7c7ba04

allows system cython packages to work

27e037f

dimpase force-pushed the yet_more_more_spkgs-confs branch from 89a6f9f to 27e037f Compare October 15, 2023 11:09

dimpase added c: packages: standard p: blocker / 1 labels Oct 15, 2023

orlitzky added s: positive review and removed s: needs review labels Oct 16, 2023

vbraun merged commit f89aaf1 into sagemath:develop Oct 21, 2023

github-actions bot removed the s: positive review label Oct 21, 2023

dimpase mentioned this pull request Nov 7, 2023

spkg-configure.m4 for python: tzdata, pytest, vcversioner #36674

Open

Uh oh!

Conversation

dimpase commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimpase commented Sep 25, 2023

Uh oh!

orlitzky commented Sep 25, 2023

Uh oh!

mkoeppe commented Sep 26, 2023

Uh oh!

dimpase commented Sep 26, 2023

Uh oh!

mkoeppe commented Sep 28, 2023

Uh oh!

dimpase commented Sep 28, 2023

Uh oh!

mkoeppe commented Sep 28, 2023

Uh oh!

dimpase commented Sep 28, 2023

Uh oh!

mkoeppe commented Sep 28, 2023

Uh oh!

mkoeppe commented Sep 30, 2023

Uh oh!

orlitzky commented Sep 30, 2023

Uh oh!

orlitzky commented Sep 30, 2023

Uh oh!

Uh oh!

dimpase commented Oct 2, 2023

Uh oh!

orlitzky commented Oct 2, 2023

Uh oh!

dimpase commented Oct 2, 2023

Uh oh!

dimpase commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orlitzky commented Oct 2, 2023

Uh oh!

dimpase commented Oct 2, 2023

Uh oh!

github-actions bot commented Oct 10, 2023

Uh oh!

orlitzky commented Oct 10, 2023

Uh oh!

mkoeppe commented Oct 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dimpase commented Sep 25, 2023 •

edited

Loading

dimpase commented Oct 2, 2023 •

edited

Loading