MPowerSeries: Don't go through symbolics to compute exp(0), log(1)#36260
Merged
vbraun merged 8 commits intosagemath:developfrom Sep 16, 2023
Merged
MPowerSeries: Don't go through symbolics to compute exp(0), log(1)#36260vbraun merged 8 commits intosagemath:developfrom
MPowerSeries: Don't go through symbolics to compute exp(0), log(1)#36260vbraun merged 8 commits intosagemath:developfrom
Conversation
added 4 commits
September 10, 2023 17:49
…ges install-requires'
orlitzky
reviewed
Sep 13, 2023
|
|
||
| sage: g = 2 + f | ||
| sage: exp(g) | ||
| sage: exp(g) # needs sage.symbolic |
Contributor
There was a problem hiding this comment.
You can avoid SR with g.exp() here and likewise in the other examples.
Contributor
Author
There was a problem hiding this comment.
Actually this error does not come from going through SR but illustrates that exp(2) does not exist in the base ring.
2 of the other # needs sage.symbolic turned out to be unnecessary due to advances in modularization. Removed in 7dde129
added 4 commits
September 13, 2023 11:56
…tools_wheel, not the ancient build/pkgs/setuptools
…d]' --probe sage.symbolic --only-tags src/sage/rings/multi_power_series_ring_element.py
|
Documentation preview for this PR (built with commit e2a76d2; changes) is ready! 🎉 |
Contributor
|
Ok, LGTM. I personally prefer |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
bootstrap#36240 (merged here)pyproject.tomlfiles #36263 (merged here)