`sage.combinat.designs`: Modularization fixes, update `# needs` by mkoeppe · Pull Request #35943 · sagemath/sage

mkoeppe · 2023-07-12T17:58:01Z

Many # optional are removed because small prime finite fields no longer need to be marked # optional/needs sage.rings.finite_rings since Integer.{perfect_power,is_prime_power,is_irreducible}: Handle easy cases without PARI #35847
Other # optional are replaced by codeblock-scoped # needs tags
Remaining # optional with standard features are replaced by # needs
Some import fixes needed for separate testing of sagemath-graphs from Modularization of sagelib: Distributions sagemath-{brial,combinat,eclib,flint,gap,giac,glpk,graphs,groups,homfly,lcalc,libbraiding,libecm,linbox,modules,mpmath,ntl,pari,plot,polyhedra,schemes,singular,standard-no-symbolics,symbolics} #35095

This is:

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

dcoudert

If I understand well, some # optional - ... statements should be # needs ....

Furthermore, for many blocks of tests/examples, we could use sage: # needs ....

dcoudert · 2023-07-13T08:07:21Z

src/sage/combinat/cluster_algebra_quiver/interact.py


-        sage: S = ClusterSeed(['A',4])                                                  # optional - sage.graphs
-        sage: S.interact()   # indirect doctest                                         # optional - sage.graphs sage.symbolic
+        sage: S = ClusterSeed(['A',4])                                                  # optional - sage.graphs sage.modules


Shouldn't it be # needs sage.graphs sage.modules ?

Actually, the whole commit making changes outside of sage.combinat.designs was not intended to be here. I'll open a separate PR for those changes.

That's now #35951

dcoudert · 2023-07-13T08:07:34Z

src/sage/combinat/cluster_algebra_quiver/mutation_class.py


        sage: from sage.combinat.cluster_algebra_quiver.mutation_class import _principal_part
-        sage: M = Matrix([[1,2],[3,4],[5,6]]); M
+        sage: M = Matrix([[1,2],[3,4],[5,6]]); M                                        # optional - sage.modules


In this file too

src/sage/combinat/cluster_algebra_quiver/quiver_mutation_type.py

src/sage/combinat/cluster_algebra_quiver/cluster_seed.py

dcoudert · 2023-07-13T08:28:06Z

src/sage/combinat/designs/incidence_structures.py

        EXAMPLES::

-            sage: designs.balanced_incomplete_block_design(7,3).is_regular()
+            sage: designs.balanced_incomplete_block_design(7,3).is_regular()            # needs sage.schemes


Why not simply using sage: # needs sage.schemes here for the block ?

The sage-fixdoctests script only does this automatically for blocks >= 4 lines
(see #35749 (comment))

dcoudert · 2023-07-13T08:29:09Z

src/sage/combinat/designs/incidence_structures.py

        EXAMPLES::

-            sage: Hypergraph(5, [[1, 2, 3], [2, 3 ,4]]).is_berge_cyclic()
+            sage: Hypergraph(5, [[1, 2, 3], [2, 3, 4]]).is_berge_cyclic()               # needs sage.modules


same here, we could use sage: # needs sage.modules.

dcoudert · 2023-07-13T08:29:46Z

src/sage/combinat/designs/incidence_structures.py


-            sage: P = IncidenceStructure([[1,2],[3,4],[2,3]]).packing()
-            sage: sorted(sorted(b) for b in P)
+            sage: P = IncidenceStructure([[1,2],[3,4],[2,3]]).packing()                 # needs sage.numerical.mip


sage: # needs sage.numerical.mip

… all --only-tags src/sage/combinat/designs/*.{py,pyx}

…ly-tags src/sage/combinat/designs/*.{py,pyx}

…eeds

github-actions · 2023-07-13T18:12:24Z

Documentation preview for this PR (built with commit f132428; changes) is ready! 🎉

dcoudert · 2023-07-14T06:47:58Z

The bot reports the following error:

sage -t --long --random-seed=286735480429121101562228604801325644303 sage/modules/free_module_element.pyx
**********************************************************************
File "sage/modules/free_module_element.pyx", line 941, in sage.modules.free_module_element.FreeModuleElement._giac_init_
Failed example:
    giac(v)+v
Expected:
    [0,2,4,6]
Got:
    Giac crashed -- automatically restarting.
    [sage0,sage1+1,sage2+2,6]

It should not be related

dcoudert

LGTM.

The error reported by the patchbot concerns giac and is not related to the changes in this PR.

mkoeppe · 2023-07-19T18:44:46Z

Thanks a lot!

Matthias Koeppe added 3 commits July 12, 2023 10:02

sage.combinat: Add # optional

a2c691c

sage.combinat: Add # optional

7f11106

sage.combinat: Add # optional

da79fa4

dcoudert requested changes Jul 13, 2023

View reviewed changes

Matthias Koeppe added 14 commits July 13, 2023 09:39

More # optional

20d4211

sage.combinat: More # optional

c9b4b06

More # optional

55a6eb9

sage.combinat: More # optional

dfb21ce

src/sage/combinat/designs/block_design.py: Style fixes

cacb502

./sage -fixdoctests --distribution 'sagemath-graphs[modules]' --probe…

8441e2c

… all --only-tags src/sage/combinat/designs/*.{py,pyx}

./sage -fixdoctests --only-tags src/sage/combinat/designs/*.{py,pyx}

355bd11

./sage -fixdoctests --distribution 'sagemath-graphs' --probe all --on…

ffe78e0

…ly-tags src/sage/combinat/designs/*.{py,pyx}

sage.combinat.designs: Update from sagemath#35095

fdbe7f7

sage.combinat.designs: Update file-level directives to use # needs

498feec

src/sage/combinat/designs/difference_family.py: Restore lost # random

a7a28fc

Do not use block # optional until sagemath#35749 is merged

e7bc5db

src/sage/combinat/designs/incidence_structures.py: Use more block # n…

74641dc

…eeds

src/sage/combinat/designs/bibd.py: Use more block # needs

f132428

dcoudert approved these changes Jul 19, 2023

View reviewed changes

dcoudert added s: positive review and removed s: needs review labels Jul 19, 2023

vbraun merged commit 4279c4e into sagemath:develop Jul 30, 2023

github-actions bot removed the s: positive review label Jul 30, 2023

Uh oh!

Conversation

mkoeppe commented Jul 12, 2023

📝 Checklist

⌛ Dependencies

Uh oh!

dcoudert left a comment

Choose a reason for hiding this comment

Uh oh!

dcoudert Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

mkoeppe Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

mkoeppe Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

dcoudert Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dcoudert Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

mkoeppe Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcoudert Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

dcoudert Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 13, 2023

Uh oh!

dcoudert commented Jul 14, 2023

Uh oh!

dcoudert left a comment

Choose a reason for hiding this comment

Uh oh!

mkoeppe commented Jul 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mkoeppe Jul 13, 2023 •

edited

Loading