sage.matroids: Update # needs, modularization fixes for imports#35919
Merged
vbraun merged 11 commits intosagemath:developfrom Jul 20, 2023
Merged
sage.matroids: Update # needs, modularization fixes for imports#35919vbraun merged 11 commits intosagemath:developfrom
sage.matroids: Update # needs, modularization fixes for imports#35919vbraun merged 11 commits intosagemath:developfrom
Conversation
added 9 commits
July 8, 2023 12:51
…dules' --only-tags --probe=sage.rings.finite_rings --overwrite src/sage/matroids/*.py
…dules' --only-tags --probe=sage.rings.finite_rings --overwrite src/sage/matroids/*.{py,pyx}
…aphs[modules]' --only-tags --probe=sage.rings.finite_rings --overwrite
dcoudert
requested changes
Jul 12, 2023
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
This is much lighter this way, in particular with the use of block statements like sage: # needs sage.graphs.
| sage: M4 = CircuitClosuresMatroid(groundset='abcdefg', | ||
| ....: circuit_closures={3: ['abcdefg'], 2: ['beg', 'cdb', 'cfg', | ||
| ....: 'ace', 'fed', 'gad', 'fab']}).dual() | ||
| sage: M1.dual() != M2 # indirect doctest # optional - sage.rings.finite_rings |
Collaborator
There was a problem hiding this comment.
Why removing the indirect doctest statement ? Isn't it useful ?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this mistake. I've restored it in 4d11269
Contributor
Author
|
Thank you! |
|
Documentation preview for this PR (built with commit 007f6ae; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
# optionalare removed because small prime finite fields no longer need to be marked# optional/needs sage.rings.finite_ringssince Integer.{perfect_power,is_prime_power,is_irreducible}: Handle easy cases without PARI #35847# optionalare replaced by codeblock-scoped# needstags# optionalwith standard features are replaced by# needsThis is:
sage -fixdoctestsfrom Add style guide / reference for# optional - sage....doctest tags, extendsage -tandsage -fixdoctestsfor modularization tasks #35749📝 Checklist
⌛ Dependencies