Reduce dependency to rainbow in sage.graphs.graph_coloring#35780
Merged
vbraun merged 3 commits intosagemath:developfrom Jun 21, 2023
Merged
Reduce dependency to rainbow in sage.graphs.graph_coloring#35780vbraun merged 3 commits intosagemath:developfrom
vbraun merged 3 commits intosagemath:developfrom
Conversation
mkoeppe
reviewed
Jun 16, 2023
src/sage/graphs/graph_coloring.pyx
Outdated
| returns a dictionary ``{color: [list of vertices]}`` | ||
|
|
||
| * ``color_classes`` -- boolean (default: ``False``); when set to ``True``, | ||
| the method returns only the color classes and ignores parameters |
Contributor
There was a problem hiding this comment.
maybe "a list of the color classes"?
mkoeppe
reviewed
Jun 16, 2023
src/sage/graphs/graph_coloring.pyx
Outdated
| the method returns only the color classes and ignores parameters | ||
| ``hex_colors`` and ``vertex_color_dict`` | ||
| the method returns only a list of the the color classes and ignores | ||
| parameters ``hex_colors`` and ``vertex_color_dict`` |
mkoeppe
approved these changes
Jun 16, 2023
Contributor
mkoeppe
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for working on this!
|
Documentation preview for this PR (built with commit e6be1da) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a method to format colorings to reduce the number of places in which method rainbow from
sage.plot.colorsis called insage.graphs.graph_coloring.This is a first step toward the resolution of #35777
📝 Checklist