sage.graphs: More modularization#35718
Merged
vbraun merged 6 commits intosagemath:developfrom Jun 11, 2023
Merged
Conversation
Contributor
Author
|
The linter failures are not coming from the PR. |
dcoudert
requested changes
Jun 4, 2023
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
I noted a few places in which the alignement of the # optional ... is different than in the other files. Otherwise, this looks good to me. I also checked the examples you changed and this seems ok.
src/sage/graphs/generic_graph.py
Outdated
| @@ -19490,8 +19538,8 @@ def latex_options(self): | |||
| sage: opts = g.latex_options() | |||
| sage: opts | |||
| LaTeX options for Petersen graph: {} | |||
| sage: opts.set_option('tkz_style', 'Classic') | |||
| sage: opts | |||
| sage: opts.set_option('tkz_style', 'Classic') # optional - sage.plot | |||
src/sage/graphs/generic_graph.py
Outdated
| sage: g.set_latex_options(tkz_style='Welsh') | ||
| sage: opts = g.latex_options() | ||
| sage: opts.get_option('tkz_style') | ||
| sage: g.set_latex_options(tkz_style='Welsh') # optional - sage.plot |
Contributor
Author
There was a problem hiding this comment.
Thanks for spotting these! Fixed now.
|
Documentation preview for this PR (built with commit 2891cd8) is ready! 🎉 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Mostly using
lazy_importand adding# optionalannotations to doctests.📝 Checklist
⌛ Dependencies