Skip to content

add macports environment to tox.ini#35667

Merged
vbraun merged 39 commits intosagemath:developfrom
dimpase:u/mkoeppe/tox_ini__add_macports_environment
Dec 26, 2023
Merged

add macports environment to tox.ini#35667
vbraun merged 39 commits intosagemath:developfrom
dimpase:u/mkoeppe/tox_ini__add_macports_environment

Conversation

@dimpase
Copy link
Copy Markdown
Member

@dimpase dimpase commented May 22, 2023

this is the branch from #31505, rebased over Sage 10.0 branch

Resolves #31505

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Sep 28, 2023

Rebased but not tested

Matthias Koeppe added 28 commits December 17, 2023 12:14
git grep -l \" build/pkgs/*/distros* | xargs sed -i.bak '/^"/s/"//g'

git grep -l -E '^([^# ]+) +([^# ][^#]+)(#.*)' build/pkgs/*/distros/*.txt | xargs sed -E -i.bak $'s/^([^# ]+) +([^# ][^#]+)(#.*)?/\\3\\\n\\1\\\n\\2/'

git grep -l -E '^([^# ]+) +([^# ][^#]+)' build/pkgs/*/distros/*.txt | xargs sed -E -i.bak $'s/^([^# ]+) +([^# ][^#]+)/\\1\\\n\\2/'

git grep -l -E ' +$' build/pkgs/*/distros/*.txt | xargs sed -E -i.bak 's/[ ]+$//'
…as configure arg, not environment variable

This is so that the presence of the environment variable at 'make' time
does not break the build when the compiler is not actually present.
@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Dec 18, 2023

@dimpase Let's merge it?

@dimpase
Copy link
Copy Markdown
Member Author

dimpase commented Dec 18, 2023

well, I don't mind if it's still in the works.

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit b5ad624; changes) is ready! 🎉

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Dec 18, 2023

OK. Already the warning message "Use of MacPorts is experimental" is certainly an improvement and better than just silently using people's MacPorts installation.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 21, 2023
sagemathgh-35667: add macports environment to tox.ini
    
this is the branch from sagemath#31505, rebased over Sage 10.0 branch

Resolves sagemath#31505

- Depends on sagemath#36910 (merged here)
    
URL: sagemath#35667
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 22, 2023
sagemathgh-35667: add macports environment to tox.ini
    
this is the branch from sagemath#31505, rebased over Sage 10.0 branch

Resolves sagemath#31505

- Depends on sagemath#36910 (merged here)
    
URL: sagemath#35667
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 23, 2023
sagemathgh-35667: add macports environment to tox.ini
    
this is the branch from sagemath#31505, rebased over Sage 10.0 branch

Resolves sagemath#31505

- Depends on sagemath#36910 (merged here)
    
URL: sagemath#35667
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 24, 2023
sagemathgh-35667: add macports environment to tox.ini
    
this is the branch from sagemath#31505, rebased over Sage 10.0 branch

Resolves sagemath#31505

- Depends on sagemath#36910 (merged here)
    
URL: sagemath#35667
Reported by: Dima Pasechnik
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 25, 2023
this is the branch from sagemath#31505, rebased over Sage 10.0 branch

Resolves sagemath#31505

- Depends on sagemath#36910 (merged here)

URL: sagemath#35667
Reported by: Dima Pasechnik
Reviewer(s):
@vbraun vbraun merged commit c0372d9 into sagemath:develop Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend system package scripts to handle macports; tox.ini: Add macports environment

3 participants