Skip to content

sage.rings.finite_rings.residue_field: Modularization fixes#35389

Merged
vbraun merged 6 commits intosagemath:developfrom
mkoeppe:residue_field_modularization
Apr 23, 2023
Merged

sage.rings.finite_rings.residue_field: Modularization fixes#35389
vbraun merged 6 commits intosagemath:developfrom
mkoeppe:residue_field_modularization

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Mar 30, 2023

📚 Description

Splitting out the implementations that depend on libraries NTL, PARI, Givaro to separate libraries.

Marking doctests # optional.

This is part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

SageMath version 10.0.beta8, Release Date: 2023-04-06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: f8caeeb

Copy link
Copy Markdown
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Apr 14, 2023

Thank you!

@vbraun vbraun merged commit 15a5078 into sagemath:develop Apr 23, 2023
dwbump pushed a commit to dwbump/sage that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants