Fix docstring of src/sage/rings/lazy_series.py#35254
Merged
vbraun merged 6 commits intosagemath:developfrom Apr 1, 2023
Merged
Fix docstring of src/sage/rings/lazy_series.py#35254vbraun merged 6 commits intosagemath:developfrom
src/sage/rings/lazy_series.py#35254vbraun merged 6 commits intosagemath:developfrom
Conversation
mantepse
reviewed
Mar 10, 2023
src/sage/rings/lazy_series.py
Outdated
| def truncate(self, d): | ||
| r""" | ||
| Return this series with its terms of degree >= ``d`` truncated. | ||
| Return this series with its terms of degree `\geq` ``d`` truncated. |
Contributor
There was a problem hiding this comment.
I think it would be clearer to write: Return the series obtained by removing all terms of degree at least ``d``.
Member
Author
There was a problem hiding this comment.
I agree! I'll change it.
Contributor
|
Thank you! |
mantepse
approved these changes
Mar 10, 2023
dcoudert
approved these changes
Mar 10, 2023
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
Much better now. Thanks.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35254 +/- ##
===========================================
+ Coverage 88.57% 88.59% +0.01%
===========================================
Files 2140 2140
Lines 397273 397415 +142
===========================================
+ Hits 351891 352078 +187
+ Misses 45382 45337 -45
... and 30 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Fixes #34610 |
|
Documentation preview for this PR is ready! 🎉 |
4 tasks
vbraun
pushed a commit
that referenced
this pull request
Apr 1, 2023
gh-35293: Arity check for shift and added some warnings <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description This address the arity problem noted in #35261. It also removes a `TODO` in a `revert()` implementation by making the behavior the same across different implementations. Warnings are added for the user for the assumptions made by the code. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> - #35127 Avoiding a long test. - #35254 Avoiding merge conflicts. - #35291 Making sure these changes work together. - #35265 For some slight simplification of the new stream's `__getitem__`. URL: #35293 Reported by: Travis Scrimshaw Reviewer(s): Martin Rubey, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
While browsing the documentation, I noticed some minor typesetting issues in
src/sage/rings/lazy_series.py. This PR aims to fix this.📝 Checklist
⌛ Dependencies