Fix doctests for nauty 2.8.6 output changes#35250
Merged
vbraun merged 1 commit intosagemath:developfrom Apr 1, 2023
Merged
Conversation
|
Documentation preview for this PR is ready! 🎉 |
dcoudert
approved these changes
Mar 9, 2023
Collaborator
dcoudert
left a comment
There was a problem hiding this comment.
I agree with these changes that make doctests compatible with multiple versions.
dcoudert
approved these changes
Mar 21, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 27, 2023
Updating to nauty 2.8.8 has one test failing. Fix it in a backwards compatible way. Note that nauty output is only debug, and the fact that sagemath tests this output is dubious (see sagemath#35250). - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36771 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 30, 2023
Updating to nauty 2.8.8 has one test failing. Fix it in a backwards compatible way. Note that nauty output is only debug, and the fact that sagemath tests this output is dubious (see sagemath#35250). - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#36771 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
See #35157 and #34133.
This changes doctests to accomodate to changes in nauty output (which are only used for debug purposes).
OTOH, there is a bug in the released nauty 2.8.6 which causes another doctest failure reported in #35157. On a system with patched nauty 2.8.6 the current PR is good enough.
Leave #35157 open. To fix it a good option might be running
gentreeg 2at configure time and check the bug is not present so it's possible to use 2.8.6 from system if it's been patched. In case it's useful, the patch I'm using is https://gitweb.gentoo.org/repo/gentoo.git/plain/sci-mathematics/nauty/files/nauty-2.8.6-gentreeg-gentourng.patch📝 Checklist
⌛ Dependencies