Skip to content

sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages#35107

Merged
vbraun merged 12 commits intosagemath:developfrom
mkoeppe:t/34957/sage__finance_interacts_libs_numerical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
Mar 19, 2023
Merged

sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages#35107
vbraun merged 12 commits intosagemath:developfrom
mkoeppe:t/34957/sage__finance_interacts_libs_numerical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Feb 13, 2023

📚 Description

Fixes #34957

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez
Copy link
Copy Markdown
Contributor

tobiasdiez commented Feb 13, 2023

Tests fail but I don't think this is a result from this PR...

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 13, 2023

Yes, that's an unrelated concurrency bug in ECL.

@mkoeppe
Merge branch 'develop' into t/34957/sage__finance_interacts_libs_nume…
accafd8 
…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
tobiasdiez
tobiasdiez previously requested changes Feb 14, 2023
View reviewed changes
@mkoeppe
Update src/sage/stats/distributions/discrete_gaussian_polynomial.py
9e0baab 
Co-authored-by: Tobias Diez <code@tobiasdiez.com>
@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 14, 2023

Thanks for catching this one; that's a peculiarity of the script, which I had fixed already by hand in other files.

@tobiasdiez
Copy link
Copy Markdown
Contributor

tobiasdiez commented Feb 14, 2023

There are a few more:

from sage.rings.integer_ring import Z as ZZ
from sage.rings.rational_field import Q as QQ

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 14, 2023

Thanks, I'll fix them with a script

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.02 ⚠️

Comparison is base (f449b14) 88.62% compared to head (a123603) 88.61%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35107      +/-   ##
===========================================
- Coverage    88.62%   88.61%   -0.02%     
===========================================
  Files         2148     2148              
  Lines       398653   398664      +11     
===========================================
- Hits        353308   353273      -35     
- Misses       45345    45391      +46
Impacted Files Coverage Δ
src/sage/libs/coxeter3/coxeter_group.py 1.35% <0.00%> (ø)
src/sage/interacts/library.py 75.03% <100.00%> (ø)
src/sage/numerical/interactive_simplex_method.py 91.89% <100.00%> (-0.13%) ⬇️
...e/stats/distributions/discrete_gaussian_lattice.py 84.48% <100.00%> (+0.41%) ⬆️
...tats/distributions/discrete_gaussian_polynomial.py 94.11% <100.00%> (+0.36%) ⬆️

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Matthias Köppe added 4 commits February 19, 2023 14:31
@mkoeppe
Merge branch 'develop' into t/34957/sage__finance_interacts_libs_nume…
3d1ad55 
…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
@mkoeppe
Merge branch 'develop' into t/34957/sage__finance_interacts_libs_nume…
d68c2af 
…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
@mkoeppe
Merge branch 'develop' into t/34957/sage__finance_interacts_libs_nume…
17f83a5 
…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
@mkoeppe
Merge branch 'develop' into t/34957/sage__finance_interacts_libs_nume…
a123603 
…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 13, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: a123603

dimpase
dimpase approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Mar 13, 2023

Thanks, Dima!

@vbraun vbraun merged commit 49c2cd3 into sagemath:develop Mar 19, 2023
vbraun pushed a commit that referenced this pull request Mar 26, 2023
80511e1 
gh-35110: Meta-PR: Replace imports from sage.*.all for namespace packages
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34201

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
- Depends on #35090
- Depends on #35098
- Depends on #35099
- Depends on #35105
- Depends on #35106
- Depends on #35107
    
URL: #35110
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mkoeppe mkoeppe

Labels

t: refactoring

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages

6 participants

@mkoeppe @tobiasdiez @codecov-commenter @dimpase @vbraun @alexchandler100