Skip to content

Trac role to GitHub#35015

Merged
vbraun merged 35 commits intosagemath:developfrom
roed314:trac_role_to_github
Feb 19, 2023
Merged

Trac role to GitHub#35015
vbraun merged 35 commits intosagemath:developfrom
roed314:trac_role_to_github

Conversation

@roed314
Copy link
Copy Markdown
Contributor

@roed314 roed314 commented Feb 8, 2023

📚 Description

Changes the :trac: role to point to github instead, and changes deprecation and stopgap warnings. Changes all the resulting urls that are printed in doctests, as well as various comments in code.

Does not update the developer documentation to explain how to use github.

@kwankyu
Copy link
Copy Markdown
Collaborator

kwankyu commented Feb 8, 2023

How about introducing a new role :gh: to replace the role of :trac: at this time? Or later in a new PR?

We may keep both for some time.

@tobiasdiez
Copy link
Copy Markdown
Contributor

Maybe a general purpose issue role, so that we don't have to change everything in a few years when we migrate to the next hip and happening platform?

@kwankyu
Copy link
Copy Markdown
Collaborator

kwankyu commented Feb 8, 2023

Never in a few years :-)

Like :trac:, I think that specificity of :gh: would explain the role more than a general purpose name. And it's short!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (12493ab) compared to base (fbb4127).
Patch coverage: 97.05% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35015      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.02%     
===========================================
  Files         2140     2140              
  Lines       396961   396958       -3     
===========================================
- Hits        351677   351634      -43     
- Misses       45284    45324      +40     
Impacted Files Coverage Δ
src/sage/algebras/free_algebra_element.py 82.50% <ø> (ø)
src/sage/algebras/fusion_rings/fusion_ring.py 93.93% <ø> (ø)
src/sage/algebras/lie_algebras/free_lie_algebra.py 95.43% <ø> (ø)
src/sage/algebras/lie_algebras/lie_algebra.py 91.10% <ø> (ø)
src/sage/algebras/lie_algebras/morphism.py 90.07% <ø> (ø)
src/sage/algebras/quatalg/quaternion_algebra.py 92.68% <ø> (ø)
src/sage/categories/category_with_axiom.py 98.71% <ø> (ø)
...age/categories/finite_complex_reflection_groups.py 79.12% <ø> (ø)
src/sage/categories/homset.py 92.66% <ø> (ø)
src/sage/categories/magmas.py 97.63% <ø> (ø)
... and 155 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@roed314
Copy link
Copy Markdown
Contributor Author

roed314 commented Feb 9, 2023

Sorry about that; I had meant to just avoid the doc directory in this PR, but accidentally ran sed one level too high in the source tree. I think the relevant files should be reverted now.

Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@dimpase
Copy link
Copy Markdown
Member

dimpase commented Feb 15, 2023

there is still a number of explicit (rewritten to URLs) trac.sagemath.org/ticket/<...> links in docstrings which should become :trac:<...>.
(in another PR)

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR is ready! 🎉
Built with commit: 12493ab

@dimpase
Copy link
Copy Markdown
Member

dimpase commented Feb 16, 2023

@vbraun - can you merge this soon? It's touching a lo of files for a good reason, and having it linger on
is entering a rebase hell...

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 16, 2023

I think the best way to request this is to mark with a high-priority label

@vbraun vbraun merged commit 9773108 into sagemath:develop Feb 19, 2023
vbraun pushed a commit that referenced this pull request Feb 24, 2023
gh-34994: fix doctests to support numpy 1.24
    
Taken from #34816.

This is necessary when system numpy is 1.24, and a prerequiste to update
numpy in sagemath.

It's probably safer at this time to merge this and leave the update for
next release.

Testing: void-linux/void-packages#42048

Depends on #35015
    
URL: #34994
Reported by: Gonzalo Tornaría
Reviewer(s): Matthias Köppe, Volker Braun
vbraun pushed a commit that referenced this pull request Mar 3, 2023
gh-35023: Remove upstream urls from checksums.ini that point to trac
    
As part of the transition to github, this PR removes some references to
the trac server from the Sage source.

### 📚 Description

I split off this PR from the main effort at #35015 since I wasn't sure
what to do with some checksum links.  After some discussion, @dimpase
and @mkoeppe noted that the links could just be deleted.  This PR will
fix #35014.
    
URL: #35023
Reported by: roed314
Reviewer(s): Dima Pasechnik
@kwankyu kwankyu mentioned this pull request Mar 21, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants