Replace curl redirector with redirect interceptor#240
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 72.08% 71.83% -0.25%
==========================================
Files 47 48 +1
Lines 2271 2397 +126
==========================================
+ Hits 1637 1722 +85
- Misses 634 675 +41
Continue to review full report at Codecov.
|
sagebind
added a commit
that referenced
this pull request
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement redirect following ourselves using an interceptor instead of using curl's redirect implementation. This ensures that redirect handling happens at a higher layer than other interceptors (such as the cookie interceptor) but also opens the door for custom redirect logic.
Fixes #232.