Skip to content

Fix Python 3 bytes string encoding when getting IAM credentials#947

Merged
fviard merged 1 commit intos3tools:masterfrom
alexallah:master
Mar 3, 2018
Merged

Fix Python 3 bytes string encoding when getting IAM credentials#947
fviard merged 1 commit intos3tools:masterfrom
alexallah:master

Conversation

@alexallah
Copy link
Copy Markdown
Contributor

@alexallah alexallah commented Jan 13, 2018

The files variable has a type of bytes() in Python 3.

For example, if files = b'master' then the request path would be formatted as
"/latest/meta-data/iam/security-credentials/b'master'"

The .decode() method converts a bytes into a proper string in Python 3 and doesn't change anything in Python 2.

@alexallah
Copy link
Copy Markdown
Contributor Author

alexallah commented Jan 13, 2018

Without the fix, I was getting this error message:

ERROR: /root/.s3cfg: None
ERROR: Configuration file not available.
ERROR: Consider using --configure parameter to create one.

@fviard fviard merged commit a018bb0 into s3tools:master Mar 3, 2018
@fviard
Copy link
Copy Markdown
Contributor

fviard commented Mar 3, 2018

Merged, thank you!

fviard added a commit to fviard/s3cmd that referenced this pull request Mar 3, 2018
@fviard
Addition to s3tools#947 - ensure it works with py2. aws requests alwa…
0ffebcf 
…ys returns utf-8 encoded data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexallah @fviard