Conversation
Contributor
Greptile SummaryThis PR fixes a bug (#309) where enabling compression together with the Key changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant C as Caller
participant RB as RequestBuilder (api.rs)
participant R as Request (client.rs)
participant EU as execute_unary_with
C->>RB: send()
RB->>R: try_clone()
alt frame_signal present (NoSideEffects retry)
Note over RB: NEW: compress BEFORE monitoring
RB->>R: compress() [sets compression=None, adds Content-Encoding header]
R-->>RB: Request{body=compressed, compression=None}
RB->>R: with_monitored_body(signal)
R-->>RB: Request{body=StreamingMonitored, compression=None}
end
RB->>EU: execute_unary(request)
EU->>EU: compress_body(body, Compression::None) → no-op
EU->>EU: build_http_request(headers already has Content-Encoding)
EU-->>RB: UnaryResponse
Last reviewed commit: 59dd131 |
Merged
shikhar
pushed a commit
that referenced
this pull request
Mar 6, 2026
## 🤖 New release * `s2-lite`: 0.29.20 -> 0.29.21 (✓ API compatible changes) * `s2-sdk`: 0.24.7 -> 0.24.8 (✓ API compatible changes) * `s2-cli`: 0.29.20 -> 0.29.21 <details><summary><i><b>Changelog</b></i></summary><p> ## `s2-lite` <blockquote> ## [0.29.21] - 2026-03-06 ### Bug Fixes - Allow http endpoints for S3-compatible object stores ([#303](#303)) - Preserve follow wait budget after lagged recovery ([#311](#311)) - Initialize durability notifier from close status ([#312](#312)) <!-- generated by git-cliff --> </blockquote> ## `s2-sdk` <blockquote> ## [0.24.8] - 2026-03-06 ### Bug Fixes - Compression and FrameSignal ordering ([#313](#313)) <!-- generated by git-cliff --> </blockquote> ## `s2-cli` <blockquote> ## [0.29.21] - 2026-03-06 <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: s2-release-plz[bot] <262023388+s2-release-plz[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309