fix: optimize out-dir display (close: #1395)#1396
Merged
drager merged 1 commit intodrager:masterfrom Jun 26, 2024
Merged
Conversation
Contributor
Author
85104fc to
fbc556c
Compare
Owner
|
I just merged #1391. Can you rebase master into this branch? :) |
Contributor
Author
The test still fails, I don't know if it is related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submittingclose: #1395
Optimize out-dir display, from
to
I'm not sure if the clean function needs to be called in other places where the display function is called, it seems that just optimizing the display of out-dir is enough