fix: update chromedriver download URL, resolve test issues#1391
Merged
drager merged 6 commits intodrager:masterfrom Jun 25, 2024
Merged
fix: update chromedriver download URL, resolve test issues#1391drager merged 6 commits intodrager:masterfrom
drager merged 6 commits intodrager:masterfrom
Conversation
Contributor
Author
|
Seems like there's some unfortunate caching issues I'll have to dig into. |
Owner
Thank you for looking into this! Appreciated! |
Contributor
Author
This issue seems to be resolved now for the sake of this PR. However, in general I've found some consistency issues with trying to determine what paths to cache when manually in many of my other projects. Are you open to switching to something like Swatinem/rust-cache or mozilla-actions/sccache-action? I've used both successfully quite a bit, though recently all of my projects have moved to the latter. If so I can open up another PR after this is cleared to merge to switch out the caching. |
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few things to get CI working for the repo again:
matches_cargoaccept both the old and new formats.macos-latestdefault, the current geckodriver setup fails for that platform.It's not entirely obvious to me why at this point. Downgrading to theEdit: It seems like the only thing preventing macOS from working was that I needed to manually install Firefox. I'm guessing this was available in the previous macOS runners by default.macos-13runner has these tests working again. This is probably the most.. questionable change as it'd be better to track down why the latest runners don't work.Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
Closes #1390