Skip to content

Privatise docsrs cfg flag #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 3 commits into from
Oct 22, 2025
Merged

Privatise docsrs cfg flag #2718

djc merged 3 commits into from
Oct 22, 2025

Conversation

@cpu
Copy link
Member

@cpu cpu commented Oct 21, 2025

cfg is a global namespace, and we don't want to trigger this in dependencies.

Backport of #2682 to rel-0.23.
Resolves #2717

ctz added 2 commits October 21, 2025 16:39
@ctz @cpu
Avoid use of docsrs cfg
2338c86 
cfg is a global namespace, and we don't want to trigger this in
dependencies.
@ctz @cpu
Remove use of doc_auto_cfg
de4941f
@cpu cpu self-assigned this Oct 21, 2025
@cpu cpu mentioned this pull request Oct 21, 2025
Closed
1 task
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.19%. Comparing base (b4597ca) to head (85671c9).
⚠️ Report is 3 commits behind head on rel-0.23.

Additional details and impacted files 
@@            Coverage Diff            @@
##           rel-0.23    #2718   +/-   ##
=========================================
  Coverage     95.19%   95.19%           
=========================================
  Files            97       97           
  Lines         21890    21890           
=========================================
  Hits          20839    20839           
  Misses         1051     1051

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Member

djc commented Oct 21, 2025

Want to publish a release?

@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Oct 21, 2025

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1578875 1603061 ⚠️ 24186 (1.53%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3933021 3983852 ⚠️ 50831 (1.29%) 0.23%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 52968879 52711155 -257724 (-0.49%) 0.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 42733073 42604318 -128755 (-0.30%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11121646 11088680 -32966 (-0.30%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11167500 11136061 -31439 (-0.28%) 1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 52792493 52646542 -145951 (-0.28%) 0.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9157997 9140318 -17679 (-0.19%) 0.66%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 52964704 52868120 -96584 (-0.18%) 0.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 42599636 42526847 -72789 (-0.17%) 0.43%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 52931102 53004863 73761 (0.14%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 52992799 52920275 -72524 (-0.14%) 0.54%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 43963623 43915169 -48454 (-0.11%) 0.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 52841118 52890900 49782 (0.09%) 0.63%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 52614904 52664098 49194 (0.09%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 52706460 52755228 48768 (0.09%) 0.59%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 52936575 52888006 -48569 (-0.09%) 0.54%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10450071 10459378 9307 (0.09%) 1.40%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 53047299 53000284 -47015 (-0.09%) 0.70%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 43975867 43939487 -36380 (-0.08%) 0.32%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 43937637 43973270 35633 (0.08%) 0.35%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 42499087 42525181 26094 (0.06%) 0.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 42605122 42629506 24384 (0.06%) 0.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 43872154 43896840 24686 (0.06%) 0.37%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 43921663 43897282 -24381 (-0.06%) 0.32%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 43967863 43944161 -23702 (-0.05%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3936120 3937532 1412 (0.04%) 0.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 52701669 52714855 13186 (0.03%) 0.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 42550948 42557424 6476 (0.02%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2487305 2487062 -243 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1581255 1581127 -128 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2484382 2484198 -184 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2765551 2765698 147 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3306950 3306866 -84 (-0.00%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9141536 9141730 194 (0.00%) 1.05%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 52771223 52772282 1059 (0.00%) 0.58%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 42627245 42626399 -846 (-0.00%) 0.35%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1286479 1286501 22 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2772517 2772473 -44 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3305517 3305485 -32 (-0.00%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1285303 1285307 4 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1721491 1721495 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7210926 7210935 9 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34737730 34737743 13 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46190736 46190729 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46022427 46022421 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92552695 92552706 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46129341 46129336 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92554344 92554335 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92592148 92592157 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80252336 80252343 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80371207 80371214 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46015536 46015540 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58028253 58028257 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58072177 58072181 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58141988 58141992 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45922788 45922785 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57921275 57921272 -3 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104989393 104989398 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80249148 80249151 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58025338 58025340 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58142009 58142007 -2 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117312739 117312742 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80360267 80360265 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46177821 46177820 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46179786 46179785 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92542714 92542716 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58131991 58131990 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80257305 80257304 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92602150 92602151 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92603447 92603446 -1 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105034436 105034437 1 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117361600 117361601 1 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31974557 31974557 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46014271 46014271 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31516944 31516944 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31635853 31635853 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30623243 30623243 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 98321 98321 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1151062 1151062 0 (0.00%) 0.44%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31638924 31638924 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2215268 2215268 0 (0.00%) 0.25%
handshake_session_id_ring_1.2_rsa_aes_server 4162880 4162880 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4230931 4230931 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1049211 1049211 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30389193 30389193 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3899027 3899027 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2338388 2338388 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30627347 30627347 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11108845 11108845 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987633 10987633 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30386425 30386425 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11114608 11114608 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31974608 31974608 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30393307 30393307 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34736027 34736027 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30548347 30548347 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32076797 32076797 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242718 2242718 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3823101 3823101 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31638632 31638632 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1209521 1209521 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1238324 1238324 0 (0.00%) 0.36%
handshake_session_id_ring_1.2_rsa_aes_client 4237416 4237416 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32076848 32076848 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58016626 58016626 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30555716 30555716 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7208974 7208974 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80357661 80357661 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32074052 32074052 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31971812 31971812 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4980598 4980598 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 74754 74754 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 111760 111760 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4617074 4617074 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30619957 30619957 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_server 2107010 2107010 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 2196722 2196722 0 (0.00%) 0.25%
handshake_session_id_ring_1.3_rsa_chacha_client 30301657 30301657 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 98264 98264 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30551612 30551612 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2071043 2071043 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4490321 4490321 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30297543 30297543 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31513873 31513873 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31516652 31516652 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2332734 2332734 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30294775 30294775 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_1.2_no_crypto 376.75 µs 372.75 µs -4.00 µs (-1.06%) 5.67%
handshake_no_resume_1.3_no_crypto 83.72 µs 84.44 µs 0.71 µs (0.85%) 8.96%
handshake_no_resume_1.2_no_crypto 75.68 µs 76.28 µs 0.60 µs (0.79%) 10.39%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.33 ms 5.36 ms 0.03 ms (0.48%) 3.79%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.42 ms 8.46 ms 0.03 ms (0.41%) 2.48%
transfer_no_resume_ring_1.3_rsa_aes 5.82 ms 5.84 ms 0.02 ms (0.40%) 3.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.23 ms 0.02 ms (0.40%) 4.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.54 ms 0.02 ms (0.40%) 5.17%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.21 ms 0.02 ms (0.36%) 4.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.44 ms 7.46 ms 0.02 ms (0.33%) 1.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.13 ms 8.16 ms 0.03 ms (0.33%) 1.44%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.12 ms 8.15 ms 0.03 ms (0.31%) 1.10%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.11 ms 8.14 ms 0.03 ms (0.31%) 1.10%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 7.95 ms 7.97 ms 0.02 ms (0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 7.95 ms 7.97 ms 0.02 ms (0.30%) 1.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.43 ms 7.45 ms 0.02 ms (0.29%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.12 ms 8.14 ms 0.02 ms (0.27%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.24 ms 7.26 ms 0.02 ms (0.26%) 1.95%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.27 ms 7.29 ms 0.02 ms (0.26%) 1.71%
handshake_session_id_1.3_no_crypto 641.47 µs 643.04 µs 1.58 µs (0.25%) 3.39%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 7.92 ms 7.94 ms 0.02 ms (0.24%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 7.93 ms 7.94 ms 0.02 ms (0.23%) 1.75%
handshake_session_id_1.2_no_crypto 337.94 µs 337.20 µs -0.73 µs (-0.22%) 6.19%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.03 ms 5.04 ms 0.01 ms (0.22%) 3.95%
handshake_no_resume_ring_1.3_rsa_aes 947.11 µs 949.10 µs 1.98 µs (0.21%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 5.75 ms 5.77 ms 0.01 ms (0.21%) 2.93%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.89 ms 12.91 ms 0.03 ms (0.21%) 1.55%
handshake_no_resume_ring_1.3_ecdsap256_chacha 455.57 µs 456.47 µs 0.90 µs (0.20%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 13.01 ms 0.03 ms (0.20%) 2.06%
transfer_no_resume_ring_1.3_rsa_chacha 13.38 ms 13.41 ms 0.03 ms (0.20%) 1.45%
handshake_session_id_ring_1.2_rsa_aes 1.46 ms 1.46 ms -0.00 ms (-0.19%) 1.93%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.67 ms 13.70 ms 0.03 ms (0.19%) 1.97%
handshake_no_resume_ring_1.3_rsa_chacha 948.32 µs 950.11 µs 1.79 µs (0.19%) 1.00%
transfer_no_resume_1.2_no_crypto 11.86 ms 11.88 ms 0.02 ms (0.17%) 1.38%
transfer_no_resume_1.3_no_crypto 11.89 ms 11.91 ms 0.02 ms (0.15%) 1.95%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.99 ms 16.01 ms 0.02 ms (0.15%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.20 ms 1.21 ms 0.00 ms (0.14%) 2.62%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.68 ms 0.02 ms (0.13%) 1.79%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 537.24 µs 537.83 µs 0.59 µs (0.11%) 2.91%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.56 ms 0.00 ms (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.44 ms 5.43 ms -0.01 ms (-0.10%) 1.12%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.09%) 1.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.22 ms 0.00 ms (0.08%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms 0.00 ms (0.07%) 1.97%
handshake_no_resume_ring_1.2_rsa_aes 941.44 µs 942.10 µs 0.66 µs (0.07%) 1.11%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.77 ms -0.00 ms (-0.07%) 2.61%
handshake_tickets_ring_1.3_rsa_aes 5.99 ms 5.98 ms -0.00 ms (-0.06%) 1.18%
handshake_tickets_ring_1.2_rsa_aes 1.54 ms 1.54 ms 0.00 ms (0.06%) 1.86%
handshake_tickets_ring_1.3_rsa_chacha 5.95 ms 5.95 ms 0.00 ms (0.06%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 540.69 µs 540.43 µs -0.25 µs (-0.05%) 2.87%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.40 ms 5.40 ms -0.00 ms (-0.04%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 5.89 ms 5.89 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.49 ms 8.50 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 5.50 ms 5.50 ms -0.00 ms (-0.03%) 1.06%
handshake_session_id_ring_1.3_rsa_aes 5.93 ms 5.92 ms -0.00 ms (-0.03%) 1.05%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.20 ms 1.20 ms 0.00 ms (0.03%) 3.03%
handshake_no_resume_ring_1.3_ecdsap256_aes 459.40 µs 459.26 µs -0.14 µs (-0.03%) 2.60%
handshake_tickets_ring_1.3_ecdsap384_aes 8.59 ms 8.59 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.46 ms 5.46 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.56 ms 8.56 ms 0.00 ms (0.00%) 1.00%
handshake_tickets_1.3_no_crypto 618.84 µs 618.81 µs -0.03 µs (-0.00%) 4.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.23 ms 1.23 ms 0.00 ms (0.00%) 1.20%
handshake_session_id_ring_1.3_ecdsap384_aes 8.52 ms 8.52 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@cpu
Copy link
Member Author

cpu commented Oct 21, 2025

Want to publish a release?

Sure, let me add a version bump commit.

@cpu cpu force-pushed the ci/cpu-backport-docs-fix branch from a90af00 to 85671c9 Compare October 21, 2025 23:13
@djc djc added this pull request to the merge queue Oct 22, 2025
Merged via the queue into rustls:rel-0.23 with commit 4cee226 Oct 22, 2025
33 checks passed
@djc djc deleted the ci/cpu-backport-docs-fix branch October 22, 2025 06:33
@djc
Copy link
Member

djc commented Oct 22, 2025

  • Published rustls v0.23.34 at registry crates-io
  • [new tag] v/0.23.34 -> v/0.23.34
  • Release notes

@cpu
Copy link
Member Author

cpu commented Oct 22, 2025

Thanks for pushing the release 🙇 My evening got away from me

@gaynor-anthropic
Copy link

gaynor-anthropic commented Oct 22, 2025

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

Assignees

@cpu cpu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpu @djc @gaynor-anthropic @ctz