Skip to content

Privatise docsrs cfg flag; fix nightly #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctz merged 2 commits into from
Sep 29, 2025
Merged

Privatise docsrs cfg flag; fix nightly #2682

ctz merged 2 commits into from
Sep 29, 2025

Conversation

@ctz
Copy link
Member

@ctz ctz commented Sep 29, 2025

cfg is a global namespace, and we don't want to trigger this in dependencies.

Related to rust-lang/rust#138907

ctz added 2 commits September 29, 2025 09:49
@ctz
Avoid use of docsrs cfg
9ddc6a8 
cfg is a global namespace, and we don't want to trigger this in
dependencies.
@ctz
Remove use of doc_auto_cfg
8503c1d
@ctz ctz changed the title Privitise docsrs cfg flag; fix nightly Privatise docsrs cfg flag; fix nightly Sep 29, 2025
@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Sep 29, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2810365 2761623 ✅ -48742 (-1.73%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9170459 9141074 -29385 (-0.32%) 0.65%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 52678846 52826022 147176 (0.28%) 0.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 53010739 52864050 -146689 (-0.28%) 0.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 52583827 52681732 97905 (0.19%) 0.72%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 52961708 52863179 -98529 (-0.19%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 52826795 52923960 97165 (0.18%) 0.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 52940781 53037956 97175 (0.18%) 0.68%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 42502628 42575985 73357 (0.17%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 43915676 43842422 -73254 (-0.17%) 0.42%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 52807800 52723232 -84568 (-0.16%) 0.49%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10452441 10468743 16302 (0.16%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11158263 11175030 16767 (0.15%) 1.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9138969 9151691 12722 (0.14%) 1.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 42454628 42503419 48791 (0.11%) 0.45%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 52991693 52932228 -59465 (-0.11%) 0.66%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 43909961 43860728 -49233 (-0.11%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3931254 3926860 -4394 (-0.11%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 43825139 43873879 48740 (0.11%) 0.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 43910303 43958904 48601 (0.11%) 0.43%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 42605847 42564917 -40930 (-0.10%) 0.31%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 52690814 52641581 -49233 (-0.09%) 0.74%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 52943283 52893945 -49338 (-0.09%) 0.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 52645256 52692817 47561 (0.09%) 0.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 43898457 43867250 -31207 (-0.07%) 0.39%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 52857934 52893345 35411 (0.07%) 0.69%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3291256 3293319 2063 (0.06%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 42557196 42532768 -24428 (-0.06%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 43909993 43885355 -24638 (-0.06%) 0.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 42534325 42557931 23606 (0.06%) 0.33%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 42582088 42601188 19100 (0.04%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3929359 3929087 -272 (-0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2768485 2768645 160 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2486208 2486090 -118 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11167310 11166806 -504 (-0.00%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2483085 2483147 62 (0.00%) 0.86%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3294577 3294653 76 (0.00%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1576297 1576326 29 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1574018 1574036 18 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1715904 1715923 19 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7214498 7214489 -9 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34733794 34733784 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46170872 46170864 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58191243 58191250 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46009739 46009744 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92597787 92597797 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92642449 92642439 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80233945 80233952 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46167565 46167569 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80342103 80342097 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45901675 45901678 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80350707 80350712 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92587661 92587656 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57954706 57954709 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58062215 58062218 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58113727 58113724 -3 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117407326 117407332 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45999064 45999062 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46111223 46111225 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58072350 58072348 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92652693 92652690 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80244623 80244621 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80348052 80348050 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46162261 46162260 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92588034 92588032 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92642857 92642855 -2 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105021889 105021891 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58060667 58060668 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58182284 58182283 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58182702 58182701 -1 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117355103 117355101 -2 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30546842 30546842 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30352341 30352341 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31860704 31860704 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30443991 30443991 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11110570 11110570 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 3393196 3393196 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 1203342 1203342 0 (0.00%) 0.50%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7216449 7216449 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80238477 80238477 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 3782098 3782098 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_server 2094841 2094841 0 (0.00%) 0.23%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31655737 31655737 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46001672 46001672 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4200100 4200100 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3809990 3809990 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 91613 91613 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 73525 73525 0 (0.00%) 0.23%
handshake_tickets_ring_1.3_rsa_chacha_client 30478757 30478757 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 100128 100128 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10955740 10955740 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34735510 34735510 0 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104969657 104969657 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1280343 1280343 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 1117727 1117727 0 (0.00%) 0.36%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30348715 30348715 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4829881 4829881 0 (0.00%) 0.40%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30471904 30471904 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1281521 1281521 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11116324 11116324 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30474611 30474611 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30544114 30544114 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 3306348 3306348 0 (0.00%) 0.30%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31860592 31860592 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31533547 31533547 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 101378 101378 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 2059824 2059824 0 (0.00%) 0.23%
handshake_no_resume_ring_1.2_rsa_aes_client 2202830 2202830 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2327311 2327311 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30437012 30437012 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31963664 31963664 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31533647 31533647 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31860706 31860706 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30550988 30550988 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 2203803 2203803 0 (0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3726539 3726539 0 (0.00%) 0.34%
handshake_session_id_1.3_no_crypto_client 2187003 2187003 0 (0.00%) 0.25%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30345362 30345362 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 1191258 1191258 0 (0.00%) 0.56%
handshake_tickets_ring_1.3_rsa_aes_server 31963666 31963666 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31963552 31963552 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 3905126 3905126 0 (0.00%) 0.25%
handshake_no_resume_ring_1.3_rsa_chacha_client 2332965 2332965 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30440365 30440365 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31655717 31655717 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 1024538 1024538 0 (0.00%) 0.68%
handshake_session_id_ring_1.3_rsa_aes_server 31655837 31655837 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31533527 31533527 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.3_no_crypto 651.33 µs 648.65 µs -2.67 µs (-0.41%) 5.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 535.91 µs 533.94 µs -1.96 µs (-0.37%) 2.19%
handshake_no_resume_1.2_no_crypto 73.83 µs 73.60 µs -0.24 µs (-0.32%) 7.56%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.75 ms 1.74 ms -0.01 ms (-0.31%) 4.53%
handshake_tickets_ring_1.3_ecdsap256_aes 5.47 ms 5.45 ms -0.02 ms (-0.30%) 1.00%
handshake_no_resume_1.3_no_crypto 81.78 µs 81.57 µs -0.21 µs (-0.26%) 7.25%
handshake_session_id_ring_1.3_rsa_aes 5.90 ms 5.88 ms -0.01 ms (-0.24%) 1.00%
handshake_tickets_1.3_no_crypto 628.69 µs 627.29 µs -1.39 µs (-0.22%) 5.57%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.43 ms 5.42 ms -0.01 ms (-0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.56 ms 8.55 ms -0.02 ms (-0.20%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.17 ms 1.17 ms -0.00 ms (-0.19%) 6.04%
handshake_tickets_ring_1.3_rsa_chacha 5.92 ms 5.91 ms -0.01 ms (-0.18%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.48 ms 4.49 ms 0.01 ms (0.17%) 3.55%
handshake_session_id_1.2_no_crypto 332.19 µs 331.62 µs -0.58 µs (-0.17%) 6.03%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.53 ms 8.51 ms -0.01 ms (-0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.40 ms 5.39 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 8.49 ms 8.48 ms -0.01 ms (-0.16%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.18 ms 1.17 ms -0.00 ms (-0.15%) 4.92%
handshake_session_id_ring_1.3_rsa_chacha 5.86 ms 5.85 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 5.95 ms 5.95 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.46 ms 8.45 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.37 ms 5.36 ms -0.01 ms (-0.13%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 5.71 ms 5.70 ms -0.01 ms (-0.12%) 2.24%
handshake_no_resume_ring_1.3_ecdsap256_aes 454.59 µs 454.04 µs -0.55 µs (-0.12%) 2.20%
handshake_tickets_1.2_no_crypto 370.62 µs 370.18 µs -0.44 µs (-0.12%) 5.51%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.30 ms 5.29 ms -0.01 ms (-0.12%) 2.50%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.13 ms 5.13 ms 0.01 ms (0.11%) 3.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.22 ms 1.22 ms -0.00 ms (-0.11%) 1.07%
handshake_no_resume_ring_1.3_rsa_chacha 945.63 µs 944.62 µs -1.01 µs (-0.11%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 8.06 ms 8.07 ms 0.01 ms (0.10%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.18 ms 5.18 ms 0.01 ms (0.10%) 2.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 7.40 ms 7.41 ms 0.01 ms (0.10%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.22 ms -0.00 ms (-0.10%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.48 ms 1.48 ms 0.00 ms (0.09%) 1.53%
handshake_no_resume_ring_1.3_ecdsap256_chacha 451.50 µs 451.12 µs -0.37 µs (-0.08%) 2.03%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.55 ms -0.00 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 532.83 µs 532.43 µs -0.40 µs (-0.07%) 2.33%
handshake_no_resume_ring_1.3_rsa_aes 943.37 µs 942.69 µs -0.67 µs (-0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 7.21 ms 7.22 ms 0.00 ms (0.06%) 1.40%
handshake_no_resume_ring_1.2_rsa_aes 934.98 µs 934.45 µs -0.53 µs (-0.06%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 7.90 ms 7.90 ms 0.00 ms (0.05%) 1.35%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.39 ms 8.39 ms -0.00 ms (-0.05%) 1.79%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 8.09 ms 8.10 ms 0.00 ms (0.05%) 1.22%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 7.87 ms 7.87 ms 0.00 ms (0.04%) 1.53%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.95 ms 15.95 ms -0.01 ms (-0.04%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.39 ms 1.39 ms -0.00 ms (-0.04%) 1.29%
transfer_no_resume_1.3_no_crypto 11.74 ms 11.73 ms -0.00 ms (-0.04%) 1.64%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 8.08 ms 8.08 ms -0.00 ms (-0.03%) 1.45%
transfer_no_resume_1.2_no_crypto 11.66 ms 11.66 ms -0.00 ms (-0.03%) 1.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 7.25 ms 7.25 ms 0.00 ms (0.02%) 1.73%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 7.91 ms 7.91 ms -0.00 ms (-0.02%) 1.73%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.05 ms -0.00 ms (-0.02%) 6.41%
transfer_no_resume_ring_1.3_rsa_aes 5.78 ms 5.78 ms 0.00 ms (0.02%) 2.69%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 8.12 ms 8.12 ms -0.00 ms (-0.02%) 1.34%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.86 ms 12.85 ms -0.00 ms (-0.02%) 1.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 7.43 ms 7.43 ms -0.00 ms (-0.01%) 1.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 7.93 ms 7.93 ms -0.00 ms (-0.01%) 1.57%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.20 ms 13.20 ms -0.00 ms (-0.01%) 1.58%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.89 ms 13.89 ms -0.00 ms (-0.01%) 1.59%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.96 ms 4.96 ms 0.00 ms (0.00%) 3.35%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.85 ms 13.85 ms -0.00 ms (-0.00%) 1.56%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.58 ms 1.58 ms -0.00 ms (-0.00%) 3.73%
transfer_no_resume_ring_1.3_rsa_chacha 13.35 ms 13.35 ms -0.00 ms (-0.00%) 1.01%

Additional information

Historical results

Checkout details:

@codecov
Copy link

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (06fd00c) to head (8503c1d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2682   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          95       95           
  Lines       21819    21819           
  Branches      614      614           
=======================================
  Hits        20689    20689           
  Misses       1002     1002           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

djc
djc approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Should we backport all/part of this to rel-0.23?

@ctz ctz added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit 02371f5 Sep 29, 2025
40 checks passed
@ctz ctz deleted the jbp-docsrs branch September 29, 2025 13:17
This was referenced Sep 29, 2025
Merged
Merged
@djc djc mentioned this pull request Oct 21, 2025
Closed
1 task
@cpu cpu mentioned this pull request Oct 21, 2025
Merged
@cpu cpu mentioned this pull request Nov 20, 2025
Merged
@djc djc mentioned this pull request Nov 26, 2025
Closed
@djc djc mentioned this pull request Jan 14, 2026
Open
joshuachp added a commit to joshuachp/rustls-native-certs that referenced this pull request Jan 14, 2026
@joshuachp
chore(docsrs): change the cfg flag to rustls_native_certs_docsrs
c29efa9 
See rustls/rustls#2682
joshuachp added a commit to joshuachp/rustls-native-certs that referenced this pull request Jan 14, 2026
@joshuachp
chore(docsrs): change the cfg flag to rustls_native_certs_docsrs
935bc12 
See rustls/rustls#2682
joshuachp added a commit to joshuachp/rustls-native-certs that referenced this pull request Jan 14, 2026
@joshuachp
chore(docsrs): change the cfg flag to rustls_native_certs_docsrs
a205d28 
See rustls/rustls#2682
joshuachp added a commit to joshuachp/rustls-native-certs that referenced this pull request Jan 14, 2026
@joshuachp
chore(docsrs): make docs.rs build work
7520286 
The nightly feature has been removed in rust 1.92, see docs.rs build
failure https://docs.rs/crate/rustls-native-certs/latest/builds/2773223
and rust PR rust-lang/rust#138907.

Also, renamed the cfg into `rustls_native_certs_docsrs`. See
rustls/rustls#2682 for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ctz @djc @cpu