Skip to content

Switch to using the pki-types crate#1432

Merged
cpu merged 3 commits intomainfrom
pki-types
Sep 5, 2023
Merged

Switch to using the pki-types crate#1432
cpu merged 3 commits intomainfrom
pki-types

Conversation

@djc
Copy link
Member

@djc djc commented Aug 30, 2023

@djc djc requested review from cpu and ctz August 30, 2023 13:33
@djc djc mentioned this pull request Aug 30, 2023
Merged
@djc djc changed the title Switch to using pki-types crate Switch to using the pki-types crate Aug 30, 2023
This was referenced Aug 31, 2023
Closed
Merged
@codecov
Copy link

codecov bot commented Sep 2, 2023 •
edited
Loading

Codecov Report

Merging #1432 (f6ea8f1) into main (95780ab) will increase coverage by 0.01%.
The diff coverage is 95.27%.

@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
+ Coverage   96.49%   96.50%   +0.01%     
==========================================
  Files          71       71              
  Lines       15160    15148      -12     
==========================================
- Hits        14628    14619       -9     
+ Misses        532      529       -3
Files Changed Coverage Δ
rustls/src/builder.rs 98.95% <ø> (ø)
rustls/src/verify.rs 63.63% <0.00%> (ø)
rustls/src/client/builder.rs 88.23% <50.00%> (ø)
rustls/src/webpki/mod.rs 71.42% <71.42%> (ø)
rustls/src/sign.rs 97.02% <98.85%> (-0.24%) ⬇️
rustls/src/client/handy.rs 98.80% <100.00%> (ø)
rustls/src/client/tls12.rs 97.96% <100.00%> (ø)
rustls/src/common_state.rs 95.38% <100.00%> (ø)
rustls/src/msgs/base.rs 90.00% <100.00%> (ø)
rustls/src/msgs/handshake.rs 98.12% <100.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc djc marked this pull request as ready for review September 2, 2023 12:28
@djc djc force-pushed the pki-types branch 4 times, most recently from 4e97d91 to 2b65076 Compare September 2, 2023 12:45
@djc
Copy link
Member Author

djc commented Sep 2, 2023

The CI benchmark failure looks like noise.

This was referenced Sep 3, 2023
Merged
Open
@djc djc added this pull request to the merge queue Sep 4, 2023
@djc
Copy link
Member Author

djc commented Sep 4, 2023

Going to merge this since @cpu is off today -- happy to address any post-merge feedback!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
cpu
cpu approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks djc!

@cpu cpu added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit c9a3974 Sep 5, 2023
@cpu cpu deleted the pki-types branch September 5, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djc @cpu @ctz