Conversation
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 96.54% 96.57% +0.02%
==========================================
Files 15 15
Lines 4376 4385 +9
==========================================
+ Hits 4225 4235 +10
+ Misses 151 150 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
commented
Aug 7, 2023
9a8beba to
ce0be38
Compare
cpu
approved these changes
Aug 30, 2023
ctz
approved these changes
Sep 1, 2023
| ALL_SIGALGS, | ||
| &anchors, | ||
| &[ca], | ||
| &[ca.clone()], |
Member
There was a problem hiding this comment.
this clone is ~free, right? because ca will be a CertificateDer(Der::Borrowed(_))?
Member
Author
There was a problem hiding this comment.
Yup, in this case ca should be a CertificateDer<'static> holding a &'static [u8].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rustls/pki-types#1 for more context.
The
cargo packageandcargo denyfailures in CI are expected given the temporary introduction of a git dependency. I'd expect we can release a pki-types 1.0.0-alpha.1 before we merge this, but want to get PRs to a bunch of other crates in place (and, ideally, reviewed) before we do that.