Add support for serializing BasicConstraints in CSR's#422
Merged
Conversation
Contributor
Author
|
It just hit me that my Would it be preferred to refactor the test or remove now & add back later when the test is possible? |
Member
Just rebase. 👍 |
djc
approved these changes
Mar 27, 2026
Member
|
Can you squash the feedback-based commits back into your original changes? |
Contributor
Author
|
Yep, commits squashed |
djc
approved these changes
Mar 31, 2026
Member
|
Thanks! |
Merged
eleboucher
pushed a commit
to eleboucher/towonel
that referenced
this pull request
May 11, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rcgen](https://github.com/rustls/rcgen) | workspace.dependencies | patch | `0.14.7` → `0.14.8` | --- ### Release Notes <details> <summary>rustls/rcgen (rcgen)</summary> ### [`v0.14.8`](https://github.com/rustls/rcgen/releases/tag/v0.14.8): 0.14.8 [Compare Source](rustls/rcgen@v0.14.7...v0.14.8) #### What's Changed - Fix incorrect identifier for ML-DSA signature algorithms by [@​DarkmatterVale](https://github.com/DarkmatterVale) in [#​412](rustls/rcgen#412) - Upgrade yasna to 0.6 by [@​djc](https://github.com/djc) in [#​419](rustls/rcgen#419) - Add support for is\_ca in CSR Params by [@​5Dev24](https://github.com/5Dev24) in [#​420](rustls/rcgen#420) - Add support for serializing BasicConstraints in CSR's by [@​5Dev24](https://github.com/5Dev24) in [#​422](rustls/rcgen#422) - update key\_pair to signing\_key in README.md by [@​fakelozic](https://github.com/fakelozic) in [#​427](rustls/rcgen#427) - Fix encoding of directoryName constraints by [@​sfackler](https://github.com/sfackler) in [#​429](rustls/rcgen#429) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/37
eleboucher
pushed a commit
to eleboucher/towonel
that referenced
this pull request
May 20, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rcgen](https://github.com/rustls/rcgen) | workspace.dependencies | patch | `0.14.7` → `0.14.8` | --- ### Release Notes <details> <summary>rustls/rcgen (rcgen)</summary> ### [`v0.14.8`](https://github.com/rustls/rcgen/releases/tag/v0.14.8): 0.14.8 [Compare Source](rustls/rcgen@v0.14.7...v0.14.8) #### What's Changed - Fix incorrect identifier for ML-DSA signature algorithms by [@​DarkmatterVale](https://github.com/DarkmatterVale) in [#​412](rustls/rcgen#412) - Upgrade yasna to 0.6 by [@​djc](https://github.com/djc) in [#​419](rustls/rcgen#419) - Add support for is\_ca in CSR Params by [@​5Dev24](https://github.com/5Dev24) in [#​420](rustls/rcgen#420) - Add support for serializing BasicConstraints in CSR's by [@​5Dev24](https://github.com/5Dev24) in [#​422](rustls/rcgen#422) - update key\_pair to signing\_key in README.md by [@​fakelozic](https://github.com/fakelozic) in [#​427](rustls/rcgen#427) - Fix encoding of directoryName constraints by [@​sfackler](https://github.com/sfackler) in [#​429](rustls/rcgen#429) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for BasicConstraints in CSR serializing.
Allows us to now both serialize (this) and deserialize (#420) BasicConstraints in CSR's.
Done so we can cover loading and storing CSR's with a BaiscConstraint attribute.