Fix regression in key usage purpose encoding#369
Merged
Merged
Conversation
ctz
reviewed
Jul 18, 2025
ctz
left a comment
Member
There was a problem hiding this comment.
For a test, how about this?
diff --git a/rcgen/src/certificate.rs b/rcgen/src/certificate.rs
index 8f625b8..9438018 100644
--- a/rcgen/src/certificate.rs
+++ b/rcgen/src/certificate.rs
@@ -1146,6 +1150,10 @@ mod tests {
for ext in cert.extensions() {
if key_usage_oid_str == ext.oid.to_id_string() {
+ // should have the minimal number of octets, and no extra trailing zero bytes
+ // ref. https://github.com/rustls/rcgen/issues/368
+ assert_eq!(ext.value, vec![0x03, 0x02, 0x05, 0xe0]);
+
if let x509_parser::extensions::ParsedExtension::KeyUsage(usage) =
ext.parsed_extension()
Member
Author
|
Thanks! I made you the commit author. 👍 |
cpu
approved these changes
Jul 18, 2025
est31
approved these changes
Jul 20, 2025
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key usage purpose encoding regressed in #287.
I don't (yet) really know what I'm doing here, just implementing @ctz's suggestion from the issue to keep this moving.
Anyone want to suggest some tests that would prevent this from regressing again? There are some tests in https://github.com/rustls/rcgen/pull/287/files#diff-1340717e703c8244b2ad18d09955bd825f1565daee83f900a26a5c956b57c125R380 but we should have something that catches this.
Fixes #368.