Add KeyUsage support to CSR generation#287
Merged
Merged
Conversation
Contributor
Author
|
I took a stab at simplifying the existing KeyUsage serialization logic. AFAICT, there seems to be no downside to unconditionally encoding KeyUsage with 9 bits—this significantly cuts down the required bit twiddling. I also took the opportunity to use the same logic for both certificates as well as CSRs. Either way—LMK your thoughts on these! |
Contributor
Author
|
I'll also add tests for this... |
djc
reviewed
Aug 7, 2024
djc
left a comment
Member
There was a problem hiding this comment.
I'd suggest reorienting the commit history as such:
- Introduce the separate
KeyUsagePurposetou16conversion method, and start using it in the same commit in place (and also other changes to always use 16 bits) - Extract the
write_key_usage()method from its current context - Add writing key usages in CSR serialization
55ceece to
1f188c5
Compare
1f188c5 to
82d10db
Compare
Contributor
Author
|
A few notes:
|
Member
It looks like the coverage job enables |
82d10db to
42f1e3e
Compare
est31
approved these changes
Aug 22, 2024
Member
|
Thanks! Sorry I didn't get a chance to take a look at this before it merged. I reviewed the diff that landed and it looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added KeyUsage support to CSR generation, as well as a number of improvements to the parsing and writing of DER-encoded key usages.
These commits can be reviewed in order!
(Coming from #285)